Investigate file access via graphics gfxWindowsPlatform::GetPlatformCMSOutputProfile

NEW
Unassigned

Status

()

Core
Graphics
18 days ago
3 days ago

People

(Reporter: jimm, Unassigned)

Tracking

Trunk
All
Windows
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sb+)

(Reporter)

Description

18 days ago
Looks like we do basic fileio here in the content process during init. Depending on the path this might be failing silently. No assertion, no return value, and the debug output goes to stderr on Windows. So if it does fail, no one would know.
(Reporter)

Comment 1

18 days ago
http://searchfox.org/mozilla-central/rev/423b2522c48e1d654e30ffc337164d677f934ec3/gfx/thebes/gfxWindowsPlatform.cpp#897
http://searchfox.org/mozilla-central/rev/423b2522c48e1d654e30ffc337164d677f934ec3/gfx/qcms/iccread.c#1292
(Reporter)

Updated

4 days ago
Flags: needinfo?(bobowencode)
Priority: -- → P3
Whiteboard: sb+
At the moment gfxWindowsPlatform::GetPlatformCMSOutputProfile appears to always be called as part of ContentChild::RecvSetXPCOMProcessAttributes, which is currently before we lower the sandbox and it should be working fine.

However, we should probably have assertions or use gfxDevCrash or something in this code, depending on how serious we think a failure is.

Clearing the priority in the hope that it gets back into a triage.
Component: Security: Process Sandboxing → Graphics
Flags: needinfo?(bobowencode)
Priority: P3 → --

Updated

3 days ago
status-firefox58: affected → ---
You need to log in before you can comment on or make changes to this bug.