1414116 - Pontoon shouldn’t import files outside of /locales or /templates

Status: RESOLVED INVALID

(Webtools Graveyard :: Pontoon, enhancement)

Description

[Théo Chevalier]

When the Buyer’s Guide files got merged into master, Pontoon imported into Mozilla Advocacy project the .properties files that we specifically put in a random folder, well away from /locales: https://github.com/mozilla/advocacy.mozilla.org/tree/master/buyers-guide-locales

Not sure if this happened because the folder contains "locales" in its name, but if I correctly understood what Matjaz told me, Pontoon wasn’t supposed to even look in that folder.

Comment 1

[Théo Chevalier]

Note: I’ve temporarily disabled the Mozilla Advocacy project, until this bug is fixed

Comment 2

[Matjaz Horvat [:mathjazz]]

Here's how detecting localizable files work:

Pontoon walks the directory tree and looks for folders named "templates", "en-US", "en-us" or "en" that contain localizable files in a supported file format. The first folder that meets the criteria is treated as source folder and all its sibling folders named as locale codes are treated as locale folders.

Everything else is ignored. So if multiple folders meet the criteria for a source folder, only the first one is used. That's what happened in your case and caused the Buyer’s Guide files to be imported into Pontoon.

Note that the "locales" folder doesn't get any special treatment, it could also be called "bla" or not exist at all (e.g. https://github.com/mozilla-l10n/www.mozilla.org).

I've updated the docs to make that clearer:
https://developer.mozilla.org/en-US/docs/Mozilla/Implementing_Pontoon_in_a_Mozilla_website

Comment 3

[Axel Hecht [:Pike]]

The real fix is going to be project config, which is bug 1385834.