1414167 - Annotate SDPs on about:webrtc with offer and answer

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Nils Ohlmeier [:drno]]

Currently the SDP's shown on about:webrtc do not show which one was the offer and which one was answer. Lets add that information to make debugging easier.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1414167 - Add offer/answer labels to local and remote sdp headings on about:webrtc.

Add a new |offerer| field to RTCStatsReport.
Based on offerer, label the local sdp as offer or answer.
Based on offerer, label the remote sdp as offer or answer.

Review commit: https://reviewboard.mozilla.org/r/200332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200332/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8929014 [details]
Bug 1414167 - Add offer/answer labels to local and remote sdp headings on about:webrtc.

https://reviewboard.mozilla.org/r/200332/#review205432

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8929014 [details]
Bug 1414167 - Add offer/answer labels to local and remote sdp headings on about:webrtc.

https://reviewboard.mozilla.org/r/200332/#review205458

LGTM

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ae93d5fd98c
Add offer/answer labels to local and remote sdp headings on about:webrtc. r=drno,smaug

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3ae93d5fd98c