1414177 - Fixed failed tests in devtools which relies on non-comformant Promise handling

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

This is a follow-up of the try result in bug 1193394 comment 48:
See dt2,3,4,6,7 of linux64-debug-build on try:
* FAIL | devtools/client/shared/test/browser_treeWidget_keyboard_interaction.js | Test timed out

* FAIL | devtools/client/responsive.html/test/browser/browser_cmd_click.js | uncaught exception
  TypeError: this.mBrowser is undefined at onLocationChange@chrome://browser/content/tabbrowser.xml:974:52
  _callProgressListeners@resource://gre/modules/RemoteWebProgress.jsm:179:11
  receiveMessage@resource://gre/modules/RemoteWebProgress.jsm:270:7

  Stack trace:
  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1652
  resource://gre/modules/RemoteWebProgress.jsm:_callProgressListeners:179
  resource://gre/modules/RemoteWebProgress.jsm:receiveMessage:270


* FAIL | devtools/client/webconsole/test/browser_console_keyboard_accessibility.js | jsterm input is not focused

  Stack trace:
      chrome://mochitests/content/browser/devtools/client/webconsole/test/browser_console_keyboard_accessibility.js:null:72
      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59


* FAIL | devtools/client/webconsole/test/browser_console_keyboard_accessibility.js | filter input is focused
  Got , expected true
  Stack trace:
      chrome://mochikit/content/browser-test.js:test_is:1010
      chrome://mochitests/content/browser/devtools/client/webconsole/test/browser_console_keyboard_accessibility.js:null:74
      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

* FAIL | devtools/client/webconsole/test/browser_console_keyboard_accessibility.js | accesskey for Network category focuses the Net button
  Got [object HTMLTextAreaElement], expected [object XULElement]
  Stack trace:
      chrome://mochikit/content/browser-test.js:test_is:1010
      chrome://mochitests/content/browser/devtools/client/webconsole/test/browser_console_keyboard_accessibility.js:null:86
      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

* FAIL | devtools/client/webconsole/test/browser_webconsole_clear_method.js | console.clear() message is still displayed
  Stack trace:
      chrome://mochitests/content/browser/devtools/client/webconsole/test/browser_webconsole_clear_method.js:null:56
      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

* FAIL | devtools/client/webconsole/test/browser_webconsole_clear_method.js | console.clear() message is only displayed once
  Got 1, expected 2
  Stack trace:
      chrome://mochikit/content/browser-test.js:test_is:1010
      chrome://mochitests/content/browser/devtools/client/webconsole/test/browser_webconsole_clear_method.js:null:58
      Tester_execTest@chrome://mochikit/content/browser-test.js:797:9
      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
      SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

* FAIL | devtools/client/inspector/boxmodel/test/browser_boxmodel_guides.js | Test timed out

* FAIL | devtools/client/debugger/test/mochitest/browser_dbg_instruments-pane-collapse_keyboard.js | The instruments panel is in the collapsed state
  Stack trace:
  chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg_instruments-pane-collapse_keyboard.js:test/</<:26
  resource://devtools/shared/base-loader.js -> resource://devtools/shared/task.js:_run:310
  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:process:922
  resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:walkerLoop:806

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Updated try result on all platforms is available now in bug 1193394 comment 58.
The updated patches are attached as well in that bug.

Comment 2

[Tooru Fujisawa [:arai]]

I'll work on them after bug 1414180 (hopefully fixed shortly)

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Closing sine all dependencies have been fixed.
Let's re-open if any new failures happened.