1414213 - WARNING: Failed to read data: file media/libstagefright/binding/include/mp4_demuxer/BufferReader.h, line 60

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[JW Wang [:jwwang] [:jw_wang]]

Got tons of warnings while playing http://92.90.207.41/.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1414213. P1 - H264::NumSPS() should return 0 if aExtraData is empty.

Review commit: https://reviewboard.mozilla.org/r/196168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196168/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8924894 [details]
Bug 1414213. P1 - H264::NumSPS() should return 0 if aExtraData is empty.

https://reviewboard.mozilla.org/r/196168/#review201346

::: media/libstagefright/binding/H264.cpp:970
(Diff revision 1)
> -  if (!aExtraData) {
> +  if (!aExtraData || aExtraData->IsEmpty()) {
>      return 0;
>    }
>  
>    BufferReader reader(aExtraData);
>    const uint8_t* ptr = reader.Read(5);

bug 1412183 introduced the problem by attempting to perform a read even when the previous operator set ptr to nullptr.

Please change this so that immediately after Read(5) it will return if ptr is nullptr.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1414213. P2 - don't continue reading if reader.Read(5) failed.

Review commit: https://reviewboard.mozilla.org/r/196538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196538/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8924894 [details]
Bug 1414213. P1 - H264::NumSPS() should return 0 if aExtraData is empty.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196168/diff/1-2/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8925413 [details]
Bug 1414213. P2 - don't continue reading if reader.Read(5) failed.

https://reviewboard.mozilla.org/r/196538/#review201750

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe1d819e6cca
P1 - H264::NumSPS() should return 0 if aExtraData is empty. r=jya
https://hg.mozilla.org/integration/autoland/rev/bbe8f6210383
P2 - don't continue reading if reader.Read(5) failed. r=jya

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fe1d819e6cca
https://hg.mozilla.org/mozilla-central/rev/bbe8f6210383