Closed Bug 1414238 Opened 7 years ago Closed 7 years ago

Optimize BaselineCompiler::emitBody a bit

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
We currently call masm.bind(labelOf(pc)) for each bytecode op, and we only have to do that for jump targets.

This improves the micro-benchmark in bug 1414228 by 5-10% so it's pretty nice.
Attachment #8924946 - Flags: review?(nicolas.b.pierron)
Component: JavaScript Engine → JavaScript Engine: JIT
Attachment #8924946 - Flags: review?(nicolas.b.pierron) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d757e71f90e
Optimize BaselineCompiler::emitBody a bit. r=nbp
https://hg.mozilla.org/mozilla-central/rev/4d757e71f90e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: