Closed
Bug 1414239
Opened 8 years ago
Closed 8 years ago
Do not include Leanplum API keys in Simulator builds
Categories
(Firefox for iOS :: Build & Test, defect, P1)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: st3fan, Assigned: st3fan)
References
Details
(Whiteboard: [MMA][Testing])
Attachments
(1 file)
Do not include Leanplum API keys in Simulator builds so that Leanplum messaging will not happen in our automation builds (tests / screenshots).
|
Assignee | |
Comment 1•8 years ago
|
||
It looks like it is difficult to check for simulator builds, so we should probably just do what we do for other API keys: check the BUDDYBUILD_SCHEME environment variable and only include Leanplum keys for "Firefox" and "FirefoxBeta".
|
|
Assignee | |
Comment 2•8 years ago
|
||
Assignee: nobody → sarentz
Attachment #8924952 -
Flags: review?(jhugman)
|
|
Assignee | |
Updated•8 years ago
|
Priority: -- → P1
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8924952 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/3415
LGTM.
Attachment #8924952 -
Flags: review?(jhugman) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Landed on master, uplifted to v10.x
|
|
Assignee | |
Comment 6•8 years ago
|
||
To be clear, this patch only includes Leanplum API keys in the Firefox and FirefoxBeta schemes. If those are built for the testing, the keys are still included. This is generally fine since we only run UI tests on our special UI Test schemes (FennecEnterprise_*)
You need to log in
before you can comment on or make changes to this bug.
Description
•