Closed
Bug 1414245
Opened 7 years ago
Closed 6 years ago
set sameProcessAsFrameLoader for options_ui and sidebar
Categories
(WebExtensions :: Frontend, enhancement, P2)
WebExtensions
Frontend
Tracking
(firefox57 wontfix, firefox61 fixed)
RESOLVED
FIXED
mozilla61
People
(Reporter: rpl, Assigned: mixedpuppy)
Details
Attachments
(1 file)
All the remote extension pages's XUL browsers sameProcessAsFrameLoader attribute should be set to the extension's groupFrameLoader (http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/toolkit/components/extensions/Extension.jsm#1126) to ensure that all the extension pages of a given extension are always going to run in the same process if more than one extension process is allowed. We should set the sameProcessAsFrameLoader attribute of the XUL browser created to embed the options_ui page in the Desktop about:addons page, similarly to what we already do for other extension pages, e.g. for the popups and the devtools panels: - http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/browser/components/extensions/ExtensionPopups.jsm#241 - http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/browser/components/extensions/ext-devtools-panels.js#230
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P2
Assignee | ||
Comment 1•6 years ago
|
||
Both sidebar and options_ui need this.
Summary: The sameProcessAsFrameLoader attribute of the options_ui XUL browsers embedded in the about:addons page should be set to the extension's groupFrameLoader → set sameProcessAsFrameLoader for options_ui and sidebar
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mixedpuppy
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8964983 [details] Bug 1414245 - set sameProcessAsFrameLoader on extension sidebar and options_ui browsers, https://reviewboard.mozilla.org/r/233726/#review239744
Attachment #8964983 -
Flags: review?(aswan) → review+
Pushed by mixedpuppy@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ad3d005f6a36 set sameProcessAsFrameLoader on extension sidebar and options_ui browsers, r=aswan
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad3d005f6a36
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•