[webdriver] Fix spelling error for unknown capabilities

RESOLVED FIXED in Firefox 58

Status

enhancement
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: whimboo, Assigned: stevea1, Mentored)

Tracking

({good-first-bug})

58 Branch
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [lang=rust])

User Story

To get started please read:
https://dxr.mozilla.org/mozilla-central/source/testing/geckodriver/CONTRIBUTING.md

Attachments

(1 attachment)

For unknown capabilities the following error message is used:

"unknown was not a the name of a known capability or a valid extension capability"

Please note the `not a the name of`:

https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/testing/webdriver/src/capabilities.rs#113

This should become: `not the name of`.
Priority: -- → P5
Comment on attachment 8925308 [details]
Bug 1414256 - [webdriver] Fix spelling error for unknown capabilities.

Correction made. I also added the verb ('is') to error message in line 133.
Comment on attachment 8925308 [details]
Bug 1414256 - [webdriver] Fix spelling error for unknown capabilities.

https://reviewboard.mozilla.org/r/196472/#review201694
Attachment #8925308 - Flags: review+
Comment on attachment 8925308 [details]
Bug 1414256 - [webdriver] Fix spelling error for unknown capabilities.

https://reviewboard.mozilla.org/r/196472/#review201850

Great. Thank you for this patch, and also for fixing the other spelling failure.
Attachment #8925308 - Flags: review?(hskupin) → review+
Assignee: nobody → stevea1
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/192367ec09cb
[webdriver] Fix spelling error for unknown capabilities. r=jgraham,whimboo
https://hg.mozilla.org/mozilla-central/rev/192367ec09cb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.