1414257 - Cookies are not cleared when leaving private browsing with "Close Private tabs" On

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 10.0 (7583)
Device: iPad Air 2
iOS: 10.3.3

Pre-requisites: 
- Go to settings and turn "Close Private tabs" On

Steps to reproduce: 
1. Open a new private tab
2. Go to gmail.com
3. Log in to gmail
4. Tap the mask button to return to Normal Browsing
5. Tap the mask button to return to Private Browsing
6. Go to gmail.com

Actual results:
- The user will be logged in to gmail. 

Expected results;
- The cookies should be cleared when leaving private browsing. 

Note:
- The cookies are correctly cleared after closing the tab and leaving private browsing.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

It is important for this to get into v10. Not only does this fix the persistent private browsing data issue, it also fixes a potential crasher that I believe is the same one that Bug 1386874 was trying to resolve. I was able to accidentally reproduce the crash while fixing the private browsing data issue and luckily, the debugger was attached :-)

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8925125 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/66f010f44cb7120a27e49955308646c63705e8db

Landed on v10.x:

https://github.com/mozilla-mobile/firefox-ios/commit/070af696cc4f43bb6df9a31b6ddf82b969723586

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on master dd49344591ff and 10.0 (7617).