Closed
Bug 1414264
Opened 7 years ago
Closed 7 years ago
All the icons paint flash on github when anything on the page changes
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | unaffected |
People
(Reporter: jrmuizel, Assigned: ethlin)
References
Details
(Whiteboard: [wr-mvp])
Attachments
(1 file)
I see this with blob images turned on. We need to understand why this happening.
|
||
Updated•7 years ago
|
Whiteboard: [wr-mvp] [triage]
|
||
Updated•7 years ago
|
Blocks: stage-wr-trains
status-firefox57:
--- → unaffected
status-firefox58:
--- → unaffected
Priority: -- → P2
|
Assignee | |
Comment 1•7 years ago
|
||
I guess it's because I use layer manager to paint SVG wrapper in bug 1413680. We always try to repaint SVG wrapper and filter[1], but actually the layer manager will calculate the invalidation region. I'll think how to fix it.
[1] https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/gfx/layers/wr/WebRenderCommandBuilder.cpp#498
Assignee: nobody → ethlin
|
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
|
Reporter | |
Comment 2•7 years ago
|
||
(In reply to Ethan Lin[:ethlin] from comment #1)
> I guess it's because I use layer manager to paint SVG wrapper in bug
> 1413680. We always try to repaint SVG wrapper and filter[1], but actually
> the layer manager will calculate the invalidation region. I'll think how to
> fix it.
>
> [1]
> https://dxr.mozilla.org/mozilla-central/rev/
> b5a3b8ef6902998507fc881b6d628b055457fe31/gfx/layers/wr/
> WebRenderCommandBuilder.cpp#498
Yeah, it looks like the icons are all inline svg.
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8925807 [details]
Bug 1414264 - Check invalidation region when we use layer system to paint items.
https://reviewboard.mozilla.org/r/196990/#review203048
Attachment #8925807 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
There are some test failures. I'll investigate more.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 8•7 years ago
|
||
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b42edef23af7
Check invalidation region when we use layer system to paint items. r=jrmuizel
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•