Closed Bug 1414264 Opened 5 years ago Closed 5 years ago

All the icons paint flash on github when anything on the page changes

Categories

(Core :: Graphics: WebRender, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected

People

(Reporter: jrmuizel, Assigned: ethlin)

References

Details

(Whiteboard: [wr-mvp])

Attachments

(1 file)

I see this with blob images turned on. We need to understand why this happening.
Whiteboard: [wr-mvp] [triage]
I guess it's because I use layer manager to paint SVG wrapper in bug 1413680. We always try to repaint SVG wrapper and filter[1], but actually the layer manager will calculate the invalidation region. I'll think how to fix it.

[1] https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/gfx/layers/wr/WebRenderCommandBuilder.cpp#498
Assignee: nobody → ethlin
Status: NEW → ASSIGNED
Priority: P2 → P1
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
(In reply to Ethan Lin[:ethlin] from comment #1)
> I guess it's because I use layer manager to paint SVG wrapper in bug
> 1413680. We always try to repaint SVG wrapper and filter[1], but actually
> the layer manager will calculate the invalidation region. I'll think how to
> fix it.
> 
> [1]
> https://dxr.mozilla.org/mozilla-central/rev/
> b5a3b8ef6902998507fc881b6d628b055457fe31/gfx/layers/wr/
> WebRenderCommandBuilder.cpp#498

Yeah, it looks like the icons are all inline svg.
Comment on attachment 8925807 [details]
Bug 1414264 - Check invalidation region when we use layer system to paint items.

https://reviewboard.mozilla.org/r/196990/#review203048
Attachment #8925807 - Flags: review?(jmuizelaar) → review+
There are some test failures. I'll investigate more.
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b42edef23af7
Check invalidation region when we use layer system to paint items. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/b42edef23af7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.