1414290 - nsWindowMemoryReporter should not call AddRef/Release on cycle collectable objects

Status: REOPENED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

nsWindowMemoryReporter does plenty of QIs and such on cycle collectable objects, by doing that if may end up affecting cycle collection and postponing deletion of some objects.

Comment 1

[Andrew McCreight [:mccr8]]

Do we run this during an incremental cycle collection? If not it shouldn't matter.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

We can do it at any point, whenever a timer runs.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This timer http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/dom/base/nsWindowMemoryReporter.cpp#830

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

oh, maybe not. There is http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/dom/base/nsWindowMemoryReporter.cpp#817

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

But even then, nsWindowMemoryReporter.cpp does end up bringing all the windows to CC graph. They might not be there otherwise, at least in theory.