Use VS2017 in NSS Windows gyp build

RESOLVED FIXED in 3.35

Status

NSS
Build
RESOLVED FIXED
19 days ago
9 days ago

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

trunk
3.35

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

19 days ago
As a followup to switching Firefox builds over to VS2017, I'm hoping to update every use of "vs2015u3" I can find in the tree.
(Assignee)

Comment 1

19 days ago
Created attachment 8925053 [details] [diff] [review]
vs2017nss

I couldn't find anything in the Gecko Try that would exercise this build, so I made these changes blindly, just based on the directory structure of the releng package.

Tim, is this something that can be tested on NSS Try?
Assignee: nobody → dmajor
Flags: needinfo?(ttaubert)
Yeah, you can push it to nss-try [1], it's an L1-accessible service just like normal try. But you'll need an NSS checkout. Let me do that :)

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=2cf297730755bb99ae70fb16874770243dcfe8c1

[1] https://wiki.mozilla.org/NSS:TryServer
Flags: needinfo?(ttaubert)
Shall we go ahead and land this? Looks good to me.
Flags: needinfo?(ttaubert)
Sure. David, any objections?
Flags: needinfo?(ttaubert) → needinfo?(dmajor)
(Assignee)

Comment 5

15 days ago
Sounds good, thanks!
Flags: needinfo?(dmajor)
https://hg.mozilla.org/projects/nss/rev/ba3a668b2e3d

Thanks David!
Status: NEW → RESOLVED
Last Resolved: 15 days ago
Resolution: --- → FIXED
Target Milestone: --- → 3.35
(Assignee)

Comment 7

12 days ago
Thanks for the review and landing! Any idea when this should reach mozilla-central? (No rush, just curious)
We'll land 3.35 after the m-c merge to beta. It should hit Nightly this week.
Oh and btw, this won't actually affect Firefox. This is only used on the NSS-specific Taskcluster infrastructure. You might know that already, just wanted to point it out :)
You need to log in before you can comment on or make changes to this bug.