Closed
Bug 1414299
Opened 7 years ago
Closed 6 years ago
Use VS2017 in OpenH264 build
Categories
(Release Engineering :: Release Requests, enhancement)
Release Engineering
Release Requests
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: away, Assigned: nthomas)
References
Details
Attachments
(3 files)
As a followup to switching Firefox builds over to VS2017, I'm hoping to update every use of "vs2015u3" I can find in the tree.
I couldn't find any Try jobs that would exercise this, so I made the changes blindly just based on the contents of the VS2017 tooltool package. Is there a way that I (or someone) can test this patch?
Flags: needinfo?(nthomas)
Flags: needinfo?(catlee)
Assignee | ||
Comment 3•7 years ago
|
||
Thanks for making the effort here David, I'll give this patch a try sometime this week.
Flags: needinfo?(catlee)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
I've taken the liberty of adding a patch before dmajor's, since the long lines for PATH, INCLUDE, and LIB definitions were making it very difficult to see what was changing. There are only formatting changes there, and I verified it would rebuild OpenH264 v1.7.1. Then attachment 8925057 [details] [diff] [review] was adapted on top of that, and some simplifying was done. I hadn't tried to minimize when I did the work for v1.7.1 but this was a good opportunity. https://blogs.msdn.microsoft.com/vcblog/2016/10/07/compiler-tools-layout-in-visual-studio-15/ describes where MS has put the various compilers, depending on host and target arch. There are some more comments in the commit message. These have been tested on a b-2008 instance (where we do compiles for now) - both win32 and win64 compiled OK and passed the OpenH264 test suite; the resulting gmp plugin dll had the right architecture.
Assignee: nobody → nthomas
Flags: needinfo?(nthomas)
Ooh, that reformatting patch plus the intra-line highlighting of mozreview makes this change much more clear. Thanks nthomas!
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8928928 [details] Bug 1414299 - Reformat PATH, LIB, and INCLUDE definitions for OpenH264 for readability, https://reviewboard.mozilla.org/r/200272/#review207088
Attachment #8928928 -
Flags: review?(bugspam.Callek) → review+
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8928929 [details] Bug 1414299 - update OpenH264 build to Visual Studio 2017 15.4.2, https://reviewboard.mozilla.org/r/200274/#review207090
Attachment #8928929 -
Flags: review?(bugspam.Callek) → review+
Comment 10•6 years ago
|
||
Pushed by nthomas@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3d421ae802d Reformat PATH, LIB, and INCLUDE definitions for OpenH264 for readability, r=Callek https://hg.mozilla.org/integration/autoland/rev/ded823ec7764 update OpenH264 build to Visual Studio 2017 15.4.2, r=Callek
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e3d421ae802d https://hg.mozilla.org/mozilla-central/rev/ded823ec7764
Updated•2 years ago
|
Component: Custom Release Requests → Release Requests
You need to log in
before you can comment on or make changes to this bug.
Description
•