Closed
Bug 1414304
Opened 7 years ago
Closed 7 years ago
Use VS2017 for the sccache toolchain build
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
4.02 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
As a followup to switching Firefox builds over to VS2017, I'm hoping to update every use of "vs2015u3" I can find in the tree.
This patch is green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc5aeacea7dc896f50be920454c8ea7c4b04c8c6&selectedJob=142006870 These .../build/src/vs2017... paths are pretty unwieldy and I tried factoring them out, but it failed horribly. Was I doing something wrong? https://hg.mozilla.org/try/rev/8a2d4b4e2c39b8c4d4e435941fe358b0fea3acba
Assignee: nobody → dmajor
Attachment #8925108 -
Flags: review?(core-build-config-reviews)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8925108 [details] [diff] [review] vs2017sccache Review of attachment 8925108 [details] [diff] [review]: ----------------------------------------------------------------- Errors on try may be the difference between "$WIN_WORKSPACE" and "$WORKSPACE" in PATH. Not really worth blocking on, thanks for the patch!
Attachment #8925108 -
Flags: review?(core-build-config-reviews) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1593366f19f3 Use VS2017 for the sccache toolchain build. r=cmanchester
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1593366f19f3
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•