Closed Bug 1414338 Opened 2 years ago Closed 10 months ago

Crash in TraceDataRelocations

Categories

(Core :: JavaScript: GC, defect, P5, critical)

56 Branch
Unspecified
Windows 10
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr52 --- affected
firefox56 --- wontfix
firefox57 --- wontfix
firefox58 --- affected

People

(Reporter: yoasif, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-ef88babf-4a3b-4023-b637-afc901171028.
=============================================================

Low volume crash; 40 crashes in the last week.
Blocks: GCCrashes
Jon, is this actionable?
Flags: needinfo?(jcoppeard)
Priority: -- → P1
Reports over the last week:
>     Firefox 58.0a1:    16
>     Firefox 57.0b*:     6
>     Firefox 56.0.*:    29
> Firefox ESR 52.4.*:     1

Reports over the last month:
>     Firefox 58.0a1:    19
>     Firefox 57.0b*:    30
>     Firefox 56.0.*:    92
> Firefox ESR 52.4.*:     6

At these volumes I don't think this will be fixed for Firefox 56/57.
(In reply to Jason Orendorff [:jorendorff] from comment #1)
There's nothing obviously wrong with this code so this is not actionable without STR.

CC'ing Jan because it's JIT related.
Flags: needinfo?(jcoppeard)
Having said that, we could add some assertions here.
Attachment #8926858 - Flags: review?(sphink)
Keywords: leave-open
Priority: P1 → P5
Attachment #8926858 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b3fdb4f8f36
Add some assertions to TraceDataRelocations r=sfink
This call to TraceDataRelocations() doesn't seem to be hit at all in our tests:

  https://searchfox.org/mozilla-central/source/js/src/jit/x86-shared/Assembler-x86-shared.cpp#94

But then again that path doesn't appear in any of the crash stacks either.
The leave-open keyword is there and there is no activity for 6 months.
:jonco, maybe it's time to close this bug?
Flags: needinfo?(jcoppeard)
This is another ongoing crash during marking.  It's still happening but is not actionable as such.  Marking as stalled.
Flags: needinfo?(jcoppeard)
Keywords: stalled

The leave-open keyword is there and there is no activity for 6 months.
:jonco, maybe it's time to close this bug?

Flags: needinfo?(jcoppeard)

There's only a handful of crashes under this signature now. Closing.

Status: NEW → RESOLVED
Closed: 10 months ago
Flags: needinfo?(jcoppeard)
Keywords: leave-open
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.