1414345 - Should insert "Frame construction" markers for nsCSSFrameConstructor::ContentAppended and friends

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P3)

Description

[Markus Stange [:mstange]]

The style flush marker won't capture this, we need an extra marker.

Comment 1

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Update_affecteds

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

This bug is related to markers but dependent bug is about label frames. Just to be sure, we are talking about the markers, right?

Comment 3

[Markus Stange [:mstange]]

Oh oops, I was confused. I thought this bug was about the label frame, but you're right, it's about markers. I suppose we could add both of them at the same time?

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1414345 - Part 1: Add 'Frame Construction' markers to all frame construction paths

Review commit: https://reviewboard.mozilla.org/r/259698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259698/

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1414345 - Part 2: Add AutoProfilerLabels for all Frame Construction paths

Review commit: https://reviewboard.mozilla.org/r/259700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/259700/

Comment 6

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

I added both of them. It will require a small PR on the perf.html side for the new markers. Preparing it now.

Comment 7

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Perf.html PR: https://github.com/devtools-html/perf.html/pull/1159

This profile includes both label frames and markers: https://deploy-preview-1159--perf-html.netlify.com/public/a0200c22a1f9058c0000ee4f343c718cfd414d17/calltree/?hiddenThreads=2&range=0.6295_1.6208~0.8550_1.5076&search=nsCSSFrameConstructor&thread=5&threadOrder=0-2-3-4-5-1&v=3

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8995203 [details]
Bug 1414345 - Part 1: Add 'Frame Construction' markers to all frame construction paths

https://reviewboard.mozilla.org/r/259698/#review267066

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 8995204 [details]
Bug 1414345 - Part 2: Add AutoProfilerLabels for all Frame Construction paths

https://reviewboard.mozilla.org/r/259700/#review267068

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45a0c8664fcf
Part 1: Add 'Frame Construction' markers to all frame construction paths r=mstange
https://hg.mozilla.org/integration/autoland/rev/147d99782475
Part 2: Add AutoProfilerLabels for all Frame Construction paths r=mstange

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/45a0c8664fcf
https://hg.mozilla.org/mozilla-central/rev/147d99782475