Closed Bug 1414461 Opened 2 years ago Closed 2 years ago

Audit Xray code for OOM problems with ensureHolder()

Categories

(Core :: XPConnect, enhancement)

53 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Bug 1407414 fixed one instance, but there are others.  For example https://crash-stats.mozilla.com/report/index/76bb3aba-c643-490f-b13c-1f99e0171027 shows a similar problem under JSXrayTraits::construct.
MozReview-Commit-ID: IV2L0f2612D
Attachment #8925220 - Flags: review?(continuation)
Comment on attachment 8925220 [details] [diff] [review]
Make sure we always null-check the result of XrayTraits::EnsureHolder

Review of attachment 8925220 [details] [diff] [review]:
-----------------------------------------------------------------

Yikes.
Attachment #8925220 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/405cc8ca7f76
Make sure we always null-check the result of XrayTraits::EnsureHolder.  r=mccr8
https://hg.mozilla.org/mozilla-central/rev/405cc8ca7f76
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.