Closed Bug 1414532 Opened 7 years ago Closed 7 years ago

Troubleshooting Information reports user.js even though it does not exist

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 58.0

People

(Reporter: Tonnes, Assigned: aceman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Starting with the regression mentioned in bug 1380797, copied clipboard info also reports a user.js even though the file does not exist. This is still valid on trunk.

Also, the message is wrapped for unknown reasons.

STR:
- Open About - Troubleshooting Information
- Click Copy text to clipboard
- Paste the clipboard text

Expected results:
There should be no report of a user.js file when it does not exist.

Actual results:
A user.js file is reported, though not present.

"Your profile folder contains a
user.js file, which includes preferences that were not created by Daily."

Last good build: Version: 54.0a1, Build ID: 20170225030215
First bad build: Version: 54.0a1, Build ID: 20170226030207
Attached patch 1414532.patch (obsolete) — Splinter Review
Caused by the mess described in bug 1386761. This element is hidden using the 'no-copy' class, which the TB version of export serialization does not obey.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #8925293 - Flags: review?(jorgk)
Blocks: 1386761
The patch must be manually tested as we do use a user.js file in any mozmill run, so the warning is there and not hidden. Only in normal profile the warning should usually be hidden.
Comment on attachment 8925293 [details] [diff] [review]
1414532.patch

Review of attachment 8925293 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. I haven't tested, but I assume you did and ran the Mozmill test as well.

::: mail/components/about-support/content/export.js
@@ +117,5 @@
>        node = nextNode;
>        continue;
>      }
> +    // Delete elements not to be copied.
> +    if (classList && classList.contains("no-copy")) {

Hmm, merge with the block above?
Attachment #8925293 - Flags: review?(jorgk) → review+
Yes I ran the test and it is now also run on try. But the test does not check for the wrong behaviour anyway.
Yes, it seems the code blocks can be merged, thanks.
Attachment #8925293 - Attachment is obsolete: true
Attachment #8925309 - Flags: review+
Keywords: checkin-needed
OS: Unspecified → All
Hardware: Unspecified → All
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/a7aa0ecabadd
do not copy elements with "no-copy" class in about:support to the clipboard. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 58.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: