Closed Bug 1414541 Opened 2 years ago Closed 2 years ago

Intermittent dom/security/test/general/test_block_toplevel_data_navigation.html | toplevel data: URI navigation through click() should be blocked

Categories

(Core :: DOM: Security, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox60 --- fixed
firefox61 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: vinoth)

Details

(Keywords: intermittent-failure, Whiteboard: [domsecurity-backlog1][stockwell unknown])

Attachments

(1 file)

Whiteboard: [domsecurity-intermittent]
Over the last 7 days there are 30 failures on this bug. These happen on Linux, Linux x64, linux32-stylo-disabled, linux64-ccov, linux64-stylo-disabled, windows10-64-ccov.

Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=163894601&lineNumber=7512

Here is a relevant part of that log: 

[task 2018-02-23T10:28:27.942Z] 10:28:27     INFO - TEST-INFO | started process screentopng
[task 2018-02-23T10:28:28.614Z] 10:28:28     INFO - TEST-INFO | screentopng: exit 0
[task 2018-02-23T10:28:28.615Z] 10:28:28     INFO - Buffered messages logged at 10:28:26
[task 2018-02-23T10:28:28.616Z] 10:28:28     INFO - TEST-PASS | dom/security/test/general/test_block_toplevel_data_navigation.html | A valid string reason is expected 
[task 2018-02-23T10:28:28.618Z] 10:28:28     INFO - TEST-PASS | dom/security/test/general/test_block_toplevel_data_navigation.html | Reason cannot be empty 
[task 2018-02-23T10:28:28.619Z] 10:28:28     INFO - TEST-FAIL | dom/security/test/general/test_block_toplevel_data_navigation.html | The author of the test has indicated that flaky timeouts are expected.  Reason: have to test that top level data: URI navgiation is blocked 
[task 2018-02-23T10:28:28.621Z] 10:28:28     INFO - Buffered messages finished
[task 2018-02-23T10:28:28.622Z] 10:28:28     INFO - TEST-UNEXPECTED-FAIL | dom/security/test/general/test_block_toplevel_data_navigation.html | toplevel data: URI navigation through click() should be blocked 
[task 2018-02-23T10:28:28.622Z] 10:28:28     INFO -     test1/<@dom/security/test/general/test_block_toplevel_data_navigation.html:25:5
[task 2018-02-23T10:28:28.623Z] 10:28:28     INFO -     setTimeout handler*SimpleTest_setTimeoutShim@SimpleTest/SimpleTest.js:676:12
[task 2018-02-23T10:28:28.624Z] 10:28:28     INFO -     test1@dom/security/test/general/test_block_toplevel_data_navigation.html:24:3
[task 2018-02-23T10:28:28.624Z] 10:28:28     INFO -     @dom/security/test/general/test_block_toplevel_data_navigation.html:82:1
[task 2018-02-23T10:28:28.625Z] 10:28:28     INFO - GECKO(2043) | ++DOCSHELL 0xe042b000 == 7 [pid = 2090] [id = {bdf011e8-d577-4550-b626-2ac4946e59e7}]
Flags: needinfo?(ckerschb)
:vino, can you take a look please?
Assignee: nobody → cegvinoth
Status: NEW → ASSIGNED
Flags: needinfo?(ckerschb) → needinfo?(cegvinoth)
Whiteboard: [domsecurity-intermittent] → [domsecurity-backlog1]
Whiteboard: [domsecurity-backlog1] → [domsecurity-backlog1][stockwell needswork]
Update:
There are 31 failures on this bug over the last week mainly on Linux and Linux32-stylo-disabled debug platforms.

:vino :ckerschb any updates on this?
(In reply to Phabricator Automation from comment #21)
> Created attachment 8960104 [details]
> Bug 1414541 -Intermittent failure fixed for toplevel data: URI

The main reason for the intermittent failure is, in test1() and test3() "document.body is null" and hence the check fails.[1]

Hence I removed the document.body approach and rewrote the tests with event messages to check if top level data: URI is blocked for both test1() and test3().

Test fails before pushing the new patch in try server.[2]
I pushed the new patch changes to try server and test passes.[3]


[1] https://dxr.mozilla.org/mozilla-central/rev/6ff60a083701d08c52702daf50f28e8f46ae3a1c/dom/security/test/general/test_block_toplevel_data_navigation.html#25

[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d6370fa69af9359e1feb15d6196d1b1178a5aa5&filter-searchStr=Linux%20debug%20Mochitests%20with%20e10s%20test-linux32%2Fdebug-mochitest-e10s-7%20M-e10s(7)&selectedJob=168842173

[3] https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5c6e25c8828bc617916bdb0b01a8285597cf972&filter-searchStr=m-e10s(7)
Flags: needinfo?(cegvinoth)
Attachment #8960104 - Flags: review?(ckerschb)
Comment on attachment 8960104 [details]
Bug 1414541 -Intermittent failure fixed for toplevel data: URI

Christoph Kerschbaumer [:ckerschb] has approved the revision.

https://phabricator.services.mozilla.com/D764
Attachment #8960104 - Flags: review+
Attachment #8960104 - Flags: review?(ckerschb)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f949048974a7
Intermittent failure fixed for toplevel data: URI. r=ckerschb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f949048974a7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.