1414554 - React 16 listeners not reported in inspector

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Adrian Wielgosik [:adrian17]]

Example: on https://reactjs.org/ in the third ("todo") example, you can't see the elements' React listeners in the Inspector.

This is because the current code (working in React 15) looks for listeners in the following subobject:

http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/devtools/server/event-parsers.js#274

node.__reactInternalInstance$1234._currentElement.props

While in React 16 I can see the listeners are stored in the following subobjects:

node.__reactInternalInstance$1234.memoizedProps
and (it seems to have the same content, at least on React homepage example)
node.reactEventHandlers$1234

Comment 1

[Patrick Brosset <:pbro>]

Thanks for filing. I see you've already investigated the issue, would you be interested in providing a fix for it? I can help find a mentor for you if that helps!

Comment 2

[Adrian Wielgosik [:adrian17]]

The reason I didn't do so is because I don't really know or use React (I only did minor unrelated work in projects using it, which is when I accidentally found the bug), so I don't feel confident I'm able to test it thoroughly or write new unit tests using React. The above analysis was based on a quick look in devtools and I think it'd be better if someone with more React experience verified and implemented this.

Comment 3

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1414554 - handle React 16 event listeners.

Tests copied directly from older versions and adapted for React 16.
React source downloaded from https://github.com/facebook/react/releases/tag/v16.2.0

Review commit: https://reviewboard.mozilla.org/r/210746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210746/

Comment 4

[Adrian Wielgosik [:adrian17]]

I gave it a shot.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8940543 [details]
Bug 1414554 - handle React 16 event listeners.

https://reviewboard.mozilla.org/r/210746/#review216568

r+ assuming green try

Comment 6

[Adrian Wielgosik [:adrian17]]

Just realized I left some testing lines in two .html files:

    class CC{
      f(){}
    }

Should I update the review, or can they be stripped on push?

Comment 7

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8940543 [details]
Bug 1414554 - handle React 16 event listeners.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210746/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dbb3bae3a99
handle React 16 event listeners. r=miker

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7dbb3bae3a99