1414597 - Inspector does not work in about:preferences page when reloading

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[magicp]

Steps to reproduce:
1. Navigate to about:preferences
2. Open Inspector (Ctrl+Shift+C)
3. Reload current page

Actual Results:
No element

Expected Results:
Inspector works even if reloading a page.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a105cf2d33a5643d63c516d5ecfe917d8eb5eeee&tochange=fb4f5c7e082a4176cd1b8f3c784e5f424417e3fa

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Any ideas about the proper fix for this Alex?

Comment 2

[Alexandre Poirot [:ochameau]]

That's because the inspector actor assumes the document supports DOMContentLoaded event,
which XUL documents like about:preferences do not support.

You should tweak the actor code accordingly wherever we wait for it:
https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/devtools/server/actors/inspector.js#2486-2491
https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/devtools/server/actors/inspector.js#2815-2831

Comment 3

[Brad Werth [:bradwerth]]

I'll figure it out.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1414597: Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau!

Comment 5

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eaa3cf851a1bb57744aea4bee444e483d3c2aa0

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 9004710 [details]
Bug 1414597: Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau!

Alexandre Poirot [:ochameau] has approved the revision.

Comment 7

[Brad Werth [:bradwerth]]

Attachment: Bug 1414597 Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=ochameau!

Depends on D4495

Comment 8

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f7d5ded2096eff18bb60f5a945584a23bf1014c

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 9005732 [details]
Bug 1414597 Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=ochameau!

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 10

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20d4e697b8bed753bde38e7e98194132369017dd

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b1229ed2850
Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a08e6206cd97
Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=jdescottes

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8b1229ed2850
https://hg.mozilla.org/mozilla-central/rev/a08e6206cd97

Comment 14

[Daniel Bodea [:danibodea]]

This issue is now fixed in Nightly v64.0a1 from 2018-10-04 in Windows 10, Ubuntu 16 and Mac OS 10.13.6.

Comment 15

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 58.0a1 (2017.10.04) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b3 on Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13.6.