Closed
Bug 1414597
Opened 6 years ago
Closed 5 years ago
Inspector does not work in about:preferences page when reloading
Categories
(DevTools :: Inspector, defect, P1)
DevTools
Inspector
Tracking
(firefox-esr52 unaffected, firefox-esr60 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 verified)
VERIFIED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | --- | wontfix |
firefox62 | --- | wontfix |
firefox63 | --- | wontfix |
firefox64 | --- | verified |
People
(Reporter: magicp.jp, Assigned: bradwerth)
References
Details
(Keywords: regression)
Attachments
(2 files)
Steps to reproduce: 1. Navigate to about:preferences 2. Open Inspector (Ctrl+Shift+C) 3. Reload current page Actual Results: No element Expected Results: Inspector works even if reloading a page. Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a105cf2d33a5643d63c516d5ecfe917d8eb5eeee&tochange=fb4f5c7e082a4176cd1b8f3c784e5f424417e3fa
Blocks: 1151909
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox56:
--- → affected
status-firefox57:
--- → affected
status-firefox58:
--- → affected
status-firefox-esr52:
--- → unaffected
Updated•6 years ago
|
Priority: -- → P1
Comment 2•6 years ago
|
||
That's because the inspector actor assumes the document supports DOMContentLoaded event, which XUL documents like about:preferences do not support. You should tweak the actor code accordingly wherever we wait for it: https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/devtools/server/actors/inspector.js#2486-2491 https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/devtools/server/actors/inspector.js#2815-2831
Flags: needinfo?(poirot.alex)
Updated•6 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Updated•6 years ago
|
Assignee: gl → nobody
Status: ASSIGNED → NEW
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Comment 3•5 years ago
|
||
I'll figure it out.
Assignee: nobody → bwerth
status-firefox56:
affected → ---
status-firefox57:
affected → ---
status-firefox58:
affected → ---
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eaa3cf851a1bb57744aea4bee444e483d3c2aa0
Comment 6•5 years ago
|
||
Comment on attachment 9004710 [details] Bug 1414597: Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau! Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9004710 -
Flags: review+
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D4495
Assignee | ||
Comment 8•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f7d5ded2096eff18bb60f5a945584a23bf1014c
Comment 9•5 years ago
|
||
Comment on attachment 9005732 [details] Bug 1414597 Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=ochameau! Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9005732 -
Flags: review+
Assignee | ||
Comment 10•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=20d4e697b8bed753bde38e7e98194132369017dd
Comment 11•5 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b1229ed2850 Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau
Comment 12•5 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a08e6206cd97 Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=jdescottes
Comment 13•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8b1229ed2850 https://hg.mozilla.org/mozilla-central/rev/a08e6206cd97
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•5 years ago
|
Keywords: regression
Updated•5 years ago
|
status-firefox62:
--- → wontfix
status-firefox63:
--- → wontfix
status-firefox-esr60:
--- → wontfix
Flags: qe-verify+
Flags: in-testsuite+
Comment 14•5 years ago
|
||
This issue is now fixed in Nightly v64.0a1 from 2018-10-04 in Windows 10, Ubuntu 16 and Mac OS 10.13.6.
Comment 15•5 years ago
|
||
I have reproduced this issue using Firefox 58.0a1 (2017.10.04) on Win 10 x64. I can confirm this issue is fixed, I verified using Firefox 64.0b3 on Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•