Closed Bug 1414597 Opened 6 years ago Closed 5 years ago

Inspector does not work in about:preferences page when reloading

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox-esr52 unaffected, firefox-esr60 wontfix, firefox62 wontfix, firefox63 wontfix, firefox64 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- verified

People

(Reporter: magicp.jp, Assigned: bradwerth)

References

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1414597: Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau!
46 bytes, text/x-phabricator-request
ochameau
: review+
Details | Review
Bug 1414597 Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=ochameau!
46 bytes, text/x-phabricator-request
jdescottes
: review+
Details | Review 
Steps to reproduce:
1. Navigate to about:preferences
2. Open Inspector (Ctrl+Shift+C)
3. Reload current page

Actual Results:
No element

Expected Results:
Inspector works even if reloading a page.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a105cf2d33a5643d63c516d5ecfe917d8eb5eeee&tochange=fb4f5c7e082a4176cd1b8f3c784e5f424417e3fa
Blocks: 1151909
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox56: --- → affected
status-firefox57: --- → affected
status-firefox58: --- → affected
status-firefox-esr52: --- → unaffected
Priority: -- → P1
Any ideas about the proper fix for this Alex?
Flags: needinfo?(poirot.alex)
That's because the inspector actor assumes the document supports DOMContentLoaded event,
which XUL documents like about:preferences do not support.

You should tweak the actor code accordingly wherever we wait for it:
https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/devtools/server/actors/inspector.js#2486-2491
https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/devtools/server/actors/inspector.js#2815-2831
Flags: needinfo?(poirot.alex)
Assignee: nobody → gl
Status: NEW → ASSIGNED
Assignee: gl → nobody
Status: ASSIGNED → NEW
Product: Firefox → DevTools
I'll figure it out.
Assignee: nobody → bwerth
status-firefox56: affected → ---
status-firefox57: affected → ---
status-firefox58: affected → ---
Comment on attachment 9004710 [details]
Bug 1414597: Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau!

Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9004710 - Flags: review+
Comment on attachment 9005732 [details]
Bug 1414597 Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=ochameau!

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9005732 - Flags: review+
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b1229ed2850
Fix devtools inspector load events to correctly listen to XUL documents. r=ochameau
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a08e6206cd97
Part 2: Add a test that nodes in XUL documents can be inspected, including after reload. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/8b1229ed2850
https://hg.mozilla.org/mozilla-central/rev/a08e6206cd97
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
status-firefox62: --- → wontfix
status-firefox63: --- → wontfix
status-firefox-esr60: --- → wontfix
Flags: qe-verify+
Flags: in-testsuite+
See Also: → 1492265
See Also: 1492265 → 
This issue is now fixed in Nightly v64.0a1 from 2018-10-04 in Windows 10, Ubuntu 16 and Mac OS 10.13.6.
status-firefox64: fixed → verified
I have reproduced this issue using Firefox 58.0a1 (2017.10.04) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b3 on Win 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.13.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.