1414609 - Filter autocomplete popup is hidden behind the floating status header

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect)

Description

[Abhinav Koppula]

STR:
1. open google.com with NetMonitor open
2. Start typing into the filter text box - for example - status-code: 200

Actual:
Autocomplete popup is hidden behind the Status header bar. (Check attachment)

Expected:
Autocomplete popup shouldn't be overlayed by anything else.

Comment 1

[Abhinav Koppula]

Attachment: filtering network requests

Comment 2

[Abhinav Koppula]

Attachment: Bug 1414609 - Changing z-index of filter autocomplete suggestion box to prevent being hidden behind netmonitor header.

Review commit: https://reviewboard.mozilla.org/r/196494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196494/

Comment 3

[Abhinav Koppula]

Hi Honza,
It looks like the below style has z-index of 1000 which overrides the autocomplete's z-index of 999.
http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/assets/styles/netmonitor.css#260

I have changed the z-index of autocomplete's searchbox to 1001.
Is it fine?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8925327 [details]
Bug 1414609 - Changing z-index of filter autocomplete suggestion box to prevent being hidden behind netmonitor header.

https://reviewboard.mozilla.org/r/196494/#review201894

Fixes the issue for me, thanks Abhinav!
R+ 

One thing, please add a comment explaing why the z-index must be bigger than 1000.

Honza

Comment 5

[Abhinav Koppula]

Comment on attachment 8925327 [details]
Bug 1414609 - Changing z-index of filter autocomplete suggestion box to prevent being hidden behind netmonitor header.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196494/diff/1-2/

Comment 6

[Abhinav Koppula]

Hi Honza,
Have added the comment.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34b559b82c03
Changing z-index of filter autocomplete suggestion box to prevent being hidden behind netmonitor header. r=Honza

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/34b559b82c03

Comment 9

[Sayed [:LiquidO2]]

I can reproduce this bug in Nightly 58.0a1 (2017-11-05) (64-bit) in 64bit Linux.

I can verify that this bug is fixed in latest Nightly.

Build ID 	20171109100107
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 10

[Md Maruf Rahman]

I can reproduce this bug with Nightly 58.0a1 (2017-11-05) in Windows 7, 64 Bit!

This bug's fix is verified  with latest Nightly!

Build ID 	20171108110838
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171108]

Comment 11

[Sayed [:LiquidO2]]

As this bug is verified in both linux(comment 9) and windows (comment 10), I am marking this bug as verified fixed.