Closed
Bug 1414627
Opened 7 years ago
Closed 7 years ago
Update string for imminent distrust message to not mention Firefox
Categories
(Core :: Security: PSM, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jcj, Assigned: jcj)
References
Details
Attachments
(1 file)
(In reply to J.C. Jones [:jcj] from https://bugzilla.mozilla.org/show_bug.cgi?id=1409259#c62:) > (In reply to Francesco Lodolo [:flod] from comment #61) > > Should it be a concern that this string will always say Firefox, since it’s > > hard coded instead of using a placeholder for the branding? Normally it > > would be, but I’m not sure in this context. > > This is my first time doing anything with strings that users see, so you'd > know better than I. That said, this is specifically a Mozilla CA Certificate > Program action, so it might be a little fuzzy? > > I think we could definitely do a follow on to either remove the branding or > add in a branding variable. We need to do it quick though before this merges > to Beta. :) > > Just as a try, what about just deleting "of Firefox": > > > certImminentDistrust.message = The security certificate in use on this web site will no longer be trusted in a future release. For more information, visit https://wiki.mozilla.org/CA/Upcoming_Distrust_Actions > > ?
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8925352 [details] Bug 1414627 - Remove mention of Firefox from Symantec distrust message https://reviewboard.mozilla.org/r/196498/#review201696 ::: browser/locales/en-US/chrome/browser/browser.properties:922 (Diff revision 1) > aboutDialog.architecture.thirtyTwoBit = 32-bit > > # LOCALIZATION NOTE (certImminentDistrust.message): > # Shown in the browser console when visiting a website that is trusted today, > # but won't be in the future unless the site operator makes a change. > -certImminentDistrust.message = The security certificate in use on this web site will no longer be trusted in a future release of Firefox. For more information, visit https://wiki.mozilla.org/CA/Upcoming_Distrust_Actions > +certImminentDistrust.message = The security certificate in use on this web site will no longer be trusted in a future release. For more information, visit https://wiki.mozilla.org/CA/Upcoming_Distrust_Actions One more nit that I didn't notice before: "web site" should be "website". http://design.firefox.com/photon/copy/word-list.html#website With that fixed, good to land for me.
Attachment #8925352 -
Flags: review?(francesco.lodolo) → review+
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8925352 [details] Bug 1414627 - Remove mention of Firefox from Symantec distrust message https://reviewboard.mozilla.org/r/196498/#review201696 Thanks, Francesco!
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c9ed5bfc1e34 Remove mention of Firefox from Symantec distrust message r=flod
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c9ed5bfc1e34
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•