1414631 - chromium: Remove the Chromium Process class

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/ipc/chromium/Unified_cpp_ipc_chromium1.cpp:2:
 In file included from /data/jenkins/workspace/firefox-clang-last/ipc/chromium/src/base/process_posix.cc:7:
 /data/jenkins/workspace/firefox-clang-last/ipc/chromium/src/base/process.h:76:10: error: private field 'last_working_set_size_' is not used [-Werror,-Wunused-private-field]
   size_t last_working_set_size_;
          ^

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1414631 - Remove the Chromium Process class

Review commit: https://reviewboard.mozilla.org/r/196506/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196506/

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

We can probably delete this entire class.  The only use seems to be a static method call at [1], which should be replaceable with GetCurrentProcId().

[1] https://searchfox.org/mozilla-central/rev/5a60492a53667fc61a62af1847d005a210b7a4f6/ipc/glue/GeckoChildProcessHost.cpp#631

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8925355 [details]
Bug 1414631 - Remove the Chromium Process class

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196506/diff/1-2/

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Comment on attachment 8925355 [details]
Bug 1414631 - Remove the Chromium Process class

https://reviewboard.mozilla.org/r/196506/#review202526

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/901652a2298b
Remove the Chromium Process class r=jld

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/901652a2298b