Closed Bug 1414644 Opened 7 years ago Closed 7 years ago

Stop unnecessarily importing XPCOMUtils.jsm into reftest-content.js

Categories

(Testing :: Reftest, enhancement)

Product:
Testing
Component:
Reftest
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

Details

Attachments

(1 file)

patch
1.21 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
XPCOMUtils.jsm only exports the symbol 'XPCOMUtils', but nothing in reftest-content.jsm uses it. So there's no reason to import XPCOMUtils.jsm into reftest-content.js.
I also noticed that XHTML_NS is not used any more either.
Attached patch patch — — Splinter Review 

        Attachment #8926016 -
        Flags: review?(dholbert)

        Attachment #8926016 -
        Flags: review?(dholbert) → review+

    
    

    
  
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2f3606eba4bc
Stop importing XPCOMUtils.jsm into reftest-content.js. r=dholbert

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2f3606eba4bc
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: