1414666 - Add nsIFrame::PresShell() for convenient access to the shell

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P5)

Description

[Mats Palmgren (inactive)]

Frame-related code often needs the PresShell so we should
add a convenience method for it instead of writing
PresContext()->PresShell() everywhere.

Comment 1

[Mats Palmgren (inactive)]

Attachment: part 1 - scripted changes

This is an automated conversion of PresContext()->PresShell()
to PresShell(), so it doesn't need careful review.
It changes a bit too much and doesn't compile, but I'll
fix the errors manually in a later patch.

I'll fold the first three patches into one before landing
so the commit message here covers all three.

Comment 2

[Mats Palmgren (inactive)]

Attachment: part 2 - add the accessor itself

Comment 3

[Mats Palmgren (inactive)]

Attachment: part 3 - manually revert a few unwanted changes from part 1

Comment 4

[Mats Palmgren (inactive)]

Attachment: A few formatting improvements after mass conversion of PresContext()->PresShell() to PresShell().

Comment 5

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aab0ac875fca72aa11b7ba42d20d7fe63098d3de

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8925375 [details] [diff] [review]
part 2 - add the accessor itself

Review of attachment 8925375 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsIFrame.h
@@ +638,5 @@
>    }
>  
>    nsPresContext* PresContext() const {
>      return StyleContext()->PresContext();
>    }

nit: Maybe leave a newline here?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8925377 [details] [diff] [review]
A few formatting improvements after mass conversion of PresContext()->PresShell() to PresShell().

Review of attachment 8925377 [details] [diff] [review]:
-----------------------------------------------------------------

Neat, thanks for doing this Mats! :)

On an unrelated note, we should probably eventually fix bug 154199... I've wondered whether to take it a couple times, but I'll finish before the imagemap thingie I think...

I always have a hard time trying to figure out the reason why something hangs off the pres shell and not pres context or vice versa, and the reason for that is probably "there's no particular reason" :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f91e74cdcf4c
part 1 - Add nsIFrame::PresShell() for convenient access to the shell.  r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/985e9aa1f587
part 2 - A few formatting improvements after mass conversion of PresContext()->PresShell() to PresShell().  r=emilio

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f91e74cdcf4c
https://hg.mozilla.org/mozilla-central/rev/985e9aa1f587