Closed Bug 1414680 Opened 2 years ago Closed 2 years ago

MediaDecoderOwner IsActive(), IsHidden() and the return value of DispatchAsyncEvent() are unused

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(2 files)

I noticed that MediaDecoderOwner::IsActive() and IsHidden() are unused in MediaDecoder, so they can be removed from MediaDecoderOwner interface.

Also, the return value of MediaDecoderOwner::DispatchAsyncEvent() is never checked, and realistically, if we failed to dispatch an event there's not a lot we can do to handle failure anyway. So we can remove the return value.
Comment on attachment 8925395 [details]
Bug 1414680 - Make MediaDecoderOwner::DispatchAsyncEvent() return void.

https://reviewboard.mozilla.org/r/196520/#review201718
Attachment #8925395 - Flags: review?(jwwang) → review+
Comment on attachment 8925394 [details]
Bug 1414680 - Remove IsActive() and IsHidden() from MediaDecoderOwner as they're unused by MediaDecoder.

https://reviewboard.mozilla.org/r/196518/#review201720
Attachment #8925394 - Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c38e1f292403
Remove IsActive() and IsHidden() from MediaDecoderOwner as they're unused by MediaDecoder. r=jwwang
https://hg.mozilla.org/integration/autoland/rev/408257c94413
Make MediaDecoderOwner::DispatchAsyncEvent() return void. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/c38e1f292403
https://hg.mozilla.org/mozilla-central/rev/408257c94413
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.