Closed Bug 1414713 Opened 6 years ago Closed 6 years ago

Get rid of EditorUtils::IsDescendantOf() which returns offset

Categories

(Core :: DOM: Editor, enhancement)

Product:
Core
Component:
DOM: Editor
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

Bug 1414713 - EditorUtils::IsDescendantOf() should take EditorDOMPoint and EditorRawDOMPoint as out param
59 bytes, text/x-review-board-request
catalinb
: review+
m_kato
: review+
Details 
      No description provided.
Comment on attachment 8925787 [details]
Bug 1414713 - EditorUtils::IsDescendantOf() should take EditorDOMPoint and EditorRawDOMPoint as out param

https://reviewboard.mozilla.org/r/196962/#review202126
Attachment #8925787 - Flags: review?(m_kato) → review+
Comment on attachment 8925787 [details]
Bug 1414713 - EditorUtils::IsDescendantOf() should take EditorDOMPoint and EditorRawDOMPoint as out param

https://reviewboard.mozilla.org/r/196962/#review202222

lgtm
Attachment #8925787 - Flags: review?(catalin.badea392) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/02c14327d145
EditorUtils::IsDescendantOf() should take EditorDOMPoint and EditorRawDOMPoint as out param r=catalinb,m_kato
https://hg.mozilla.org/mozilla-central/rev/02c14327d145
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.