Control center shadow is intermittently different on OSX

RESOLVED FIXED in Firefox 59

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

(Blocks: 1 bug)

Version 3
mozilla59
All
macOS
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

a year ago
I'll make another bug in graphics and attach a patch here to disable the shadow in the short term.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
See Also: → bug 1425253
Comment on attachment 8936849 [details]
Bug 1414741 - Hide identity popup shadow using a class name instead of setting inline styles.

https://reviewboard.mozilla.org/r/207570/#review213518
Attachment #8936849 - Flags: review?(MattN+bmo) → review+

Comment 5

a year ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/691b38288b18
Disable control center shadow in mozscreenshots. r=MattN

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/691b38288b18
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Assignee)

Comment 7

a year ago
This did not work on our test machines apparently, though it worked for me locally. Reopening to take another look at it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (mozreview-request)
(Assignee)

Comment 10

a year ago
Comment on attachment 8936849 [details]
Bug 1414741 - Hide identity popup shadow using a class name instead of setting inline styles.

Ah, forgot to set the review flag.
Attachment #8936849 - Flags: review+ → review?(MattN+bmo)
Comment on attachment 8936849 [details]
Bug 1414741 - Hide identity popup shadow using a class name instead of setting inline styles.

https://reviewboard.mozilla.org/r/207570/#review215452

It's not ideal to have this in shipping code when it's only used by mozscreenshots and the real issue is the intermittent difference but I'm ok with it for now. Thanks
Attachment #8936849 - Flags: review?(MattN+bmo) → review+

Comment 12

a year ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/49699f5a94f6
Hide identity popup shadow using a class name instead of setting inline styles. r=MattN

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/49699f5a94f6
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.