Closed
Bug 1414741
Opened 7 years ago
Closed 6 years ago
Control center shadow is intermittently different on OSX
Categories
(Testing :: mozscreenshots, defect)
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: johannh, Assigned: johannh)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I'm not sure what's going on exactly but variations of this: https://screenshots.mattn.ca/comparisons/mozilla-central/d3910b7628b8066d3f30d58b17b5824b05768854/mozilla-central/acc9f95343e7cf385c24f256f0cdf305c4af77a2/osx-10-10/controlCenter_074_compactLight_mixedPassive.png have been showing up very frequently in the last months.
|
Assignee | |
Comment 1•6 years ago
|
||
I'll make another bug in graphics and attach a patch here to disable the shadow in the short term.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a2755b66f95ec8f1a6a000d22ed52a2103c3419
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936849 [details] Bug 1414741 - Hide identity popup shadow using a class name instead of setting inline styles. https://reviewboard.mozilla.org/r/207570/#review213518
Attachment #8936849 -
Flags: review?(MattN+bmo) → review+
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/691b38288b18 Disable control center shadow in mozscreenshots. r=MattN
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/691b38288b18
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
|
Assignee | |
Comment 7•6 years ago
|
||
This did not work on our test machines apparently, though it worked for me locally. Reopening to take another look at it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 8•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2fc1789df900f98b1cd7713da1fec789ffe3ceff
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 10•6 years ago
|
||
Comment on attachment 8936849 [details] Bug 1414741 - Hide identity popup shadow using a class name instead of setting inline styles. Ah, forgot to set the review flag.
Attachment #8936849 -
Flags: review+ → review?(MattN+bmo)
|
|
||
Comment 11•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8936849 [details] Bug 1414741 - Hide identity popup shadow using a class name instead of setting inline styles. https://reviewboard.mozilla.org/r/207570/#review215452 It's not ideal to have this in shipping code when it's only used by mozscreenshots and the real issue is the intermittent difference but I'm ok with it for now. Thanks
Attachment #8936849 -
Flags: review?(MattN+bmo) → review+
|
||
Comment 12•6 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/49699f5a94f6 Hide identity popup shadow using a class name instead of setting inline styles. r=MattN
|
|
||
Comment 13•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/49699f5a94f6
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•