secport.c fix signed / unsigned mismatch

RESOLVED FIXED in 3.35

Status

NSS
Libraries
RESOLVED FIXED
19 days ago
18 days ago

People

(Reporter: jbonnafo, Assigned: jbonnafo)

Tracking

trunk
3.35

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

19 days ago
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

I have compiled code using Visual Studio 2017 and the compiler reports a warning about signed / unsigned mismatch


Actual results:

Compiler reported the following warning:
security/nss/lib/util/secport.c:793 [C4018] '<': signed/unsigned mismatch


Expected results:

Code should have compiled without any warning.
Comment on attachment 8925447 [details]
Bug 1414747 - secport.c fix signed / unsigned mismatch

Tim Taubert [:ttaubert] has approved the revision.

https://phabricator.services.mozilla.com/D192#4820
Attachment #8925447 - Flags: review+
Assignee: nobody → jeanluc.bonnafoux
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
BTW, for the next time, please submit a patch against the NSS repository [1]. Firefox just uses a copy of NSS but we usually work on the upstream repo. Thanks!

[1] https://hg.mozilla.org/projects/nss
https://hg.mozilla.org/projects/nss/rev/c710811a5cc7
Status: ASSIGNED → RESOLVED
Last Resolved: 18 days ago
Resolution: --- → FIXED
Target Milestone: --- → 3.35
(Assignee)

Comment 4

18 days ago
Hello,

Thanks for the review and comment. Does it mean i have to do a dedicated pull request for code changes on NSS ?

Thanks,
You basically should have a separate checkout of NSS (without the surrounding Firefox code) and then call "arc diff" in there.
You need to log in before you can comment on or make changes to this bug.