45 bytes, text/x-phabricator-request
|Details | Review|
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20171024165158 Steps to reproduce: I have compiled code using Visual Studio 2017 and the compiler reports a warning about signed / unsigned mismatch Actual results: Compiler reported the following warning: security/nss/lib/util/secport.c:793 [C4018] '<': signed/unsigned mismatch Expected results: Code should have compiled without any warning.
Comment on attachment 8925447 [details] Bug 1414747 - secport.c fix signed / unsigned mismatch Tim Taubert [:ttaubert] has approved the revision. https://phabricator.services.mozilla.com/D192#4820
BTW, for the next time, please submit a patch against the NSS repository . Firefox just uses a copy of NSS but we usually work on the upstream repo. Thanks!  https://hg.mozilla.org/projects/nss
Hello, Thanks for the review and comment. Does it mean i have to do a dedicated pull request for code changes on NSS ? Thanks,
You basically should have a separate checkout of NSS (without the surrounding Firefox code) and then call "arc diff" in there.