1414760 - Fix calling a function without resolving its declaration.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, enhancement)

Description

[James Cheng[:JamesCheng]]

I find that we can pass the compilation by the benefit of the unified build.

We should not count on that.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1414760 - Fix calling a function without resolving its declaration.

Review commit: https://reviewboard.mozilla.org/r/196578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196578/

Comment 2

[John Lin [:jhlin][:jolin]]

Comment on attachment 8925451 [details]
Bug 1414760 - Fix calling a function without resolving its declaration.

https://reviewboard.mozilla.org/r/196578/#review201806

::: dom/media/platforms/android/AndroidDecoderModule.h:34
(Diff revision 1)
>    RefPtr<MediaDrmCDMProxy> mProxy;
>  };
>  
>  extern LazyLogModule sAndroidDecoderModuleLog;
>  
> +const char*

Good catch!

Alternatively, just keep this function private and translate MIME-type in `AndroidDecoderModule::CreateVideoDecoder` instead. (Extra copy of `CreateDecoderParams` is needed, though.)

::: dom/media/platforms/android/RemoteDataDecoder.cpp:546
(Diff revision 1)
>    mFormat = nullptr;
>  
>    return ShutdownPromise::CreateAndResolve(true, __func__);
>  }
>  
> +CryptoInfo::LocalRef

`static`?

Comment 3

[James Cheng[:JamesCheng]]

Comment on attachment 8925451 [details]
Bug 1414760 - Fix calling a function without resolving its declaration.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196578/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb947ac4fa87
Fix calling a function without resolving its declaration. r=jolin

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bb947ac4fa87