Closed
Bug 1414760
Opened 8 years ago
Closed 8 years ago
Fix calling a function without resolving its declaration.
Categories
(Firefox for Android Graveyard :: Audio/Video, enhancement)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
Details
Attachments
(1 file)
I find that we can pass the compilation by the benefit of the unified build.
We should not count on that.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8925451 [details]
Bug 1414760 - Fix calling a function without resolving its declaration.
https://reviewboard.mozilla.org/r/196578/#review201806
::: dom/media/platforms/android/AndroidDecoderModule.h:34
(Diff revision 1)
> RefPtr<MediaDrmCDMProxy> mProxy;
> };
>
> extern LazyLogModule sAndroidDecoderModuleLog;
>
> +const char*
Good catch!
Alternatively, just keep this function private and translate MIME-type in `AndroidDecoderModule::CreateVideoDecoder` instead. (Extra copy of `CreateDecoderParams` is needed, though.)
::: dom/media/platforms/android/RemoteDataDecoder.cpp:546
(Diff revision 1)
> mFormat = nullptr;
>
> return ShutdownPromise::CreateAndResolve(true, __func__);
> }
>
> +CryptoInfo::LocalRef
`static`?
Attachment #8925451 -
Flags: review?(jolin) → review+
Comment hidden (mozreview-request) |
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb947ac4fa87
Fix calling a function without resolving its declaration. r=jolin
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•