Closed Bug 1414760 Opened 3 years ago Closed 3 years ago

Fix calling a function without resolving its declaration.

Categories

(Firefox for Android :: Audio/Video, enhancement)

Product:
Firefox for Android
Component:
Audio/Video
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

Details

Attachments

(1 file)

Bug 1414760 - Fix calling a function without resolving its declaration.
59 bytes, text/x-review-board-request
jhlin
: review+
Details 
I find that we can pass the compilation by the benefit of the unified build.

We should not count on that.
Comment on attachment 8925451 [details]
Bug 1414760 - Fix calling a function without resolving its declaration.

https://reviewboard.mozilla.org/r/196578/#review201806

::: dom/media/platforms/android/AndroidDecoderModule.h:34
(Diff revision 1)
>    RefPtr<MediaDrmCDMProxy> mProxy;
>  };
>  
>  extern LazyLogModule sAndroidDecoderModuleLog;
>  
> +const char*

Good catch!

Alternatively, just keep this function private and translate MIME-type in `AndroidDecoderModule::CreateVideoDecoder` instead. (Extra copy of `CreateDecoderParams` is needed, though.)

::: dom/media/platforms/android/RemoteDataDecoder.cpp:546
(Diff revision 1)
>    mFormat = nullptr;
>  
>    return ShutdownPromise::CreateAndResolve(true, __func__);
>  }
>  
> +CryptoInfo::LocalRef

`static`?
Attachment #8925451 - Flags: review?(jolin) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb947ac4fa87
Fix calling a function without resolving its declaration. r=jolin
https://hg.mozilla.org/mozilla-central/rev/bb947ac4fa87
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.