Moving SlicedInputStream under mozilla namespace

RESOLVED FIXED in Firefox 58

Status

()

enhancement
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

This is similar to what we have for other inputStreams without 'ns' prefix in the name.
Assignee: nobody → amarchesini
Attachment #8925459 - Flags: review?(nfroyd)
Comment on attachment 8925459 [details] [diff] [review]
namespace.patch

Review of attachment 8925459 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.  One nit below.

::: xpcom/io/SlicedInputStream.h
@@ +85,1 @@
>  #endif // SlicedInputStream_h

Nit: please change the include guards for this file to be mozilla_SlicedInputStream_h as well.
Attachment #8925459 - Flags: review?(nfroyd) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66d49b9e8217
Moving SlicedInputStream under mozilla namespace, r=froydnj
Backed out for build bustage on OS X: CoreServices.framework/Frameworks/AE.framework/Headers/AERegistry.h:693: reference to 'TextRange' is ambiguous:

https://hg.mozilla.org/integration/mozilla-inbound/rev/efbec0bdf3736290e1f2f0cb233da1ff3e292d78

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=66d49b9e821754962568f8f65dddde7cc242a15e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=142458122&repo=mozilla-inbound

[task 2017-11-06T16:27:21.331Z] 16:27:21     INFO -  In file included from /builds/worker/workspace/build/src/obj-firefox/dist/include/nsILocalFileMac.h:17:
[task 2017-11-06T16:27:21.332Z] 16:27:21     INFO -  In file included from /builds/worker/workspace/build/src/MacOSX10.11.sdk/System/Library/Frameworks/Carbon.framework/Headers/Carbon.h:20:
[task 2017-11-06T16:27:21.332Z] 16:27:21     INFO -  In file included from /builds/worker/workspace/build/src/MacOSX10.11.sdk/System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:23:
[task 2017-11-06T16:27:21.333Z] 16:27:21     INFO -  In file included from /builds/worker/workspace/build/src/MacOSX10.11.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/AE.framework/Headers/AE.h:41:
[task 2017-11-06T16:27:21.334Z] 16:27:21     INFO -  /builds/worker/workspace/build/src/MacOSX10.11.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/AE.framework/Headers/AERegistry.h:693:16: error: reference to 'TextRange' is ambiguous
[task 2017-11-06T16:27:21.334Z] 16:27:21     INFO -  typedef struct TextRange                TextRange;
[task 2017-11-06T16:27:21.335Z] 16:27:21     INFO -                 ^
...
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f5a502acbe8
Moving SlicedInputStream under mozilla namespace, r=froydnj
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/4f5a502acbe8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.