Closed
Bug 1414774
Opened 7 years ago
Closed 7 years ago
sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton are not initialized
Categories
(Core :: Widget: Gtk, enhancement)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(1 file)
Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1413166#c15
sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton looks like static values but they are not static ones so we need to initialize them.
Assignee | ||
Updated•7 years ago
|
Summary: sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton is not initialized → sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton are not initialized
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8925476 [details]
Bug 1414774 - Initialize sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton,
https://reviewboard.mozilla.org/r/196596/#review201848
Attachment #8925476 -
Flags: review?(jhorak) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/d45a801da041
Initialize sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton, r=jhorak
Comment 4•7 years ago
|
||
I was going to say that static variables don't need this since they are
guaranteed to be initialized to null/zero/false by the language. But I was
mislead because these members are not named correctly per our coding style:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Prefixes
"s=static member (e.g. sPrefChecked)"
Please file a follow-up bug on renaming all these members:
http://searchfox.org/mozilla-central/rev/5a60492a53667fc61a62af1847d005a210b7a4f6/widget/gtk/nsLookAndFeel.h#54-91
Flags: needinfo?(stransky)
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #4)
> I was going to say that static variables don't need this since they are
> guaranteed to be initialized to null/zero/false by the language. But I was
> mislead because these members are not named correctly per our coding style:
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Coding_Style#Prefixes
> "s=static member (e.g. sPrefChecked)"
>
> Please file a follow-up bug on renaming all these members:
> http://searchfox.org/mozilla-central/rev/
> 5a60492a53667fc61a62af1847d005a210b7a4f6/widget/gtk/nsLookAndFeel.h#54-91
Sure, filed as Bug 1415080.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(stransky)
Updated•6 years ago
|
Assignee: nobody → stransky
You need to log in
before you can comment on or make changes to this bug.
Description
•