Closed Bug 1414774 Opened 3 years ago Closed 3 years ago
CSDClose Button/s CSDMaximize Button/s CSDMinimize Button are not initialized
59 bytes, text/x-review-board-request
Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1413166#c15 sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton looks like static values but they are not static ones so we need to initialize them.
Summary: sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton is not initialized → sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton are not initialized
Comment on attachment 8925476 [details] Bug 1414774 - Initialize sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton, https://reviewboard.mozilla.org/r/196596/#review201848
Attachment #8925476 - Flags: review?(jhorak) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d45a801da041 Initialize sCSDCloseButton/sCSDMaximizeButton/sCSDMinimizeButton, r=jhorak
I was going to say that static variables don't need this since they are guaranteed to be initialized to null/zero/false by the language. But I was mislead because these members are not named correctly per our coding style: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Prefixes "s=static member (e.g. sPrefChecked)" Please file a follow-up bug on renaming all these members: http://searchfox.org/mozilla-central/rev/5a60492a53667fc61a62af1847d005a210b7a4f6/widget/gtk/nsLookAndFeel.h#54-91
(In reply to Mats Palmgren (:mats) from comment #4) > I was going to say that static variables don't need this since they are > guaranteed to be initialized to null/zero/false by the language. But I was > mislead because these members are not named correctly per our coding style: > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/ > Coding_Style#Prefixes > "s=static member (e.g. sPrefChecked)" > > Please file a follow-up bug on renaming all these members: > http://searchfox.org/mozilla-central/rev/ > 5a60492a53667fc61a62af1847d005a210b7a4f6/widget/gtk/nsLookAndFeel.h#54-91 Sure, filed as Bug 1415080.
You need to log in before you can comment on or make changes to this bug.