1414786 - Crash in SelectorMatchesTree when enabling the master password.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1414513

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1414786: Do not match caption's labels with child combinators.

Nested captions are not used, nor nested labels inside captions.

Another approach would be to just move all our captions that currently use
<caption><label> to use <caption label="">, and get rid of the <xbl:children>
element.

Let me know if that's preferred, but seems not necessary to me.

Review commit: https://reviewboard.mozilla.org/r/196628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196628/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Note that part of this patch is already reviewed in bug 1414544.

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8925492 [details]
Bug 1414786: Do not match caption's labels with child combinators.

https://reviewboard.mozilla.org/r/196628/#review201876

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66212b8b4315
Do not match caption's labels with child combinators. r=dao

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/66212b8b4315