Fix test for expired certificate "helpful" messaging to users with broken system clocks

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: Gijs, Assigned: johannh)

Tracking

(Blocks 1 bug)

57 Branch
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

2 years ago
In bug 1339329 we restrict the circumstances in which we show users a message about their system clock being off. Unfortunately, we do not currently have test certificates in our mochitest infrastructure that allow us to test this feature properly in automated testing. Adding one proved non-trivial, and Mark said he may be able to help with this.
Flags: needinfo?(mgoodwin)
(Assignee)

Updated

10 months ago
Depends on: 1456089
(Assignee)

Updated

10 months ago
Priority: -- → P3
(Assignee)

Updated

7 months ago
(Assignee)

Comment 1

7 months ago
I'm adding docs in bug 1456089 and I can re-enable the test afterwards.
Flags: needinfo?(mgoodwin)
(Assignee)

Comment 2

5 months ago
While I wanted to do this I realized that we don't actually need bug 1456089, patch coming up...
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
No longer depends on: 1456089
Attachment #9029318 - Attachment is obsolete: true

Comment 5

5 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4002b751596e
Fix test for expired certificate "helpful" messaging to users with broken system clocks. r=Gijs

Comment 6

5 months ago
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cc51c29fddc
Backed out changeset 4002b751596e for browser_aboutCertError_clockSkew.js failures CLOSED TREE
(Assignee)

Comment 7

4 months ago

A needinfo on this would have been nice...

Comment 8

4 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a140784a7b05
Fix test for expired certificate "helpful" messaging to users with broken system clocks. r=Gijs

Comment 9

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.