Closed
Bug 1414813
Opened 7 years ago
Closed 7 years ago
pk11merge.c fix signed / unsigned compilation warning
Categories
(NSS :: Libraries, defect)
NSS
Libraries
Tracking
(Not tracked)
RESOLVED
FIXED
3.35
People
(Reporter: jeanluc.bonnafoux, Assigned: jeanluc.bonnafoux)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Build ID: 20171024165158 Steps to reproduce: Using Visual studio 2017, i have compiled NSS and it raised some warnings Actual results: pk11merge.c fix signed / unsigned compilation warning raised Expected results: Compilation should not produce warnings.
Hello, I have submitted a patch proposal but arc command also took previous change i did today in another file. What is the best way to have arc taking only one file ? i have tried arc diff <commitid> with no luck Thanks,
Hello, i have updated the patch proposal following your feedback. The patch has only the relevant file. Thanks,
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8925513 [details] Bug 1414777 - pkcs11uri.c fix unsigned / signed mismatch Tim Taubert [:ttaubert] has approved the revision. https://phabricator.services.mozilla.com/D195#5239
Attachment #8925513 -
Flags: review+
|
||
Updated•7 years ago
|
Assignee: nobody → jeanluc.bonnafoux
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/15ffe14f15e0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.35
You need to log in
before you can comment on or make changes to this bug.
Description
•