1414822 - release_history object should be populated for desktop only

Status: NEW

(Release Engineering :: General, enhancement)

Description

[Rail Aliiev [:rail]]

I just realized that we populate the `release_history` object for all kind of nightly decision tasks, including Android.

Comment 1

[Rail Aliiev [:rail]]

Attachment: nightly_desktop.diff

Simon, what do you think about this change? Also, before I submit it for review, do you mind if I rename `populate_release_history()` to something like `populate_nighlty_release_history()`.

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

Comment on attachment 8925506 [details] [diff] [review]
nightly_desktop.diff

I'd update the comment as well, but it looks good. Are we worried about cases where people trigger a nightly for a specific platform? 


desktop_nightlies = [
    'nightly_linux',
    'nightly_macosx',
    'nightly_win32',
    'nightly_win64',
    'nightly_desktop',

]
if parameters.get('target_tasks_method') and parameters.get('target_tasks_method') in desktop_nightlies:

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

Renaming the function is a good idea. The TC folks may prefer us renaming the mach command as well, as release_history is too broad.

Comment 4

[Rail Aliiev [:rail]]

Ah, good point. I wonder if we can distinguish nightlies by product...

Comment 5

[Simon Fraser [:sfraser] ⌚️GMT]

There doesn't seem to be an easy way of doing that.  The --force-run parameter makes it through taskcluster/taskgraph/cron/* as job_name, but that ends up only in the human readable fields, the scopes, and the routes. It seems that we either update .taskcluster.yml to add it to the parameters, or do the long-winded check.

Comment 6

[Simon Fraser [:sfraser] ⌚️GMT]

Should we just go ahead with checking for nightly_desktop and seeing if it breaks things?

Comment 7

[Rail Aliiev [:rail]]

Back to the pool, I won't be around for a while