1414890 - blob-images: massively increasing memory consumption on Google Slides

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Attachment: 2017-11-06_18-35-46.mp4

Nightly 58 x64 20171106100122 de_DE 179dae92e4d794e7f45ad080ff01908c80691f31 @ Debian Testing (KDE, Radeon RX480)
fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled, gfx.webrender.blob-images

See Nightly's memory consumption in the attached video.
This does not happen when blob-images is disabled.

1. Open https://docs.google.com/presentation/d/1OVtXAnyeBLX2N1yyZoTMP9AV_6HnI3mnXwIFlOL7yOA/edit
2. Click on some items on the left. With blob-images there is a noticeably delay between the click and highlighting.
3. Move your mouse over the slide on the right and scroll down. Watch your memory consumption while scrolling

(I assume this freezed my desktop some minutes ago when I used my main profile.)

Comment 1

[Darkspirit]

> (I assume this freezed my desktop some minutes ago when I used my main profile.)
PS: I had luck and could Alt+F4/Ctrl+Q Nightly then which unfreezed my desktop:
bp-abd8bbc9-d71b-41fe-8284-d59d90171106 06.11.17 18:12 [@ IPCError-browser | ShutDownKill ]
bp-78369bc8-28b8-48f2-a91a-21e150171106 06.11.17 18:12 [@ IPCError-browser | ShutDownKill ]

The GPU process (fresh profile: firefox process) doesn't release those 5+ GB RAM when I close that tab.
(But a font crash from bug 1412545 just made my GPU process to a zombie and I got a new one with low memory usage.)

Comment 2

[Ethan Lin[:ethlin]]

I guess it's same as bug 1418374. I'll check it.

Comment 3

[Ethan Lin[:ethlin]]

The patch in bug 1418374 seems to fix the Google Slides memory problem. :darkspirit, could you confirm it?

Comment 4

[Darkspirit]

1. open https://docs.google.com/presentation/d/1OVtXAnyeBLX2N1yyZoTMP9AV_6HnI3mnXwIFlOL7yOA/edit
2. Move your mouse to the center of the page and scroll down to slide 56. This will take some time.
3. Wait until all images are loaded.

mozregression --find-fix --bad 2017-11-06 --good 2017-11-22 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"
> 20:15.46 INFO: No more inbound revisions, bisection finished.
> 20:15.46 INFO: First good revision: 5378dcb45044a160fad93b02eed0c617f3324dbc
> 20:15.46 INFO: Last bad revision: b96f009478987d44a68a8d7cad40c6a3d6626235
> 20:15.46 INFO: Pushlog:
> https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b96f009478987d44a68a8d7cad40c6a3d6626235&tochange=5378dcb45044a160fad93b02eed0c617f3324dbc
> 
> 20:18.99 INFO: ************* Switching to autoland by process of elimination (no branch detected in commit message)
> 20:19.00 INFO: Getting autoland builds between ed6b21b2945d9ea4aa156ea079ea20d200d4a6a7 and 5378dcb45044a160fad93b02eed0c617f3324dbc
> 20:19.47 ERROR: The url u'https://hg.mozilla.org/integration/autoland/json-pushes?fromchange=5378dcb45044a160fad93b02eed0c617f3324dbc&tochange=ed6b21b2945d9ea4aa156ea079ea20d200d4a6a7' contains no pushlog. Maybe use another range ?

Memory usage of the firefox process:
20171122220056 554MB good
20171106100122 6 GB bad
20171114220116 6 GB bad
20171118220429 6 GB bad
20171120222519 8 GB bad
20171121220115 6 GB bad
switching to taskcluster
20171122184621 8697764f 517 MB good
20171122095759 5378dcb4 468 MB good
20171122040747 b96f0094 5 GB bad
switching to autoland: no pushlog.

mozregression --repo autoland --launch <revision> --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"
> 517 MB 5378dcb45044	Fred Lin — Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer
> 506 MB 931eb8bca980	Michal Stanke — Bug 1419117 - [cs] Update icons of Firefox desktop search modules and use https, r=flod
> 525 MB d56832437a0b	KuoE0 — Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild(). r=TYLin
> 516 MB 1a65a4910d55	Ethan Lin — Bug 1418374 - Discard blob image key when we create another new one. r=kats
> 5 GB   de1df00a5bba	Cameron McCormack — Bug 1419652 - Remove HandleRefPtr. r=TYLin
> 5 GB   00a08154f505	Hiroyuki Ikezoe — Bug 1418867 - Crash test for the case where the parent element has no style data for pseudo. r=emilio
>        [...]
> 6 GB   22f422e17767	Daosheng Mu — Bug 1409677 - Adjust kCommonAliasedLineWidthRangeMax to 1 in WebGL resistFingerprint mode; r=cfu,jgilbert
>        [...]
> 6 GB   14207d5c28f8	Edgar Chen — Bug 1419313 - Add [CEReactions] to contentEditable attribute; r=smaug

Jackpot! Yes, bug 1418374 fixed this.

WebRender vs. Non-WebRender:
1a65a4910d55	Ethan Lin — Bug 1418374 - Discard blob image key when we create another new one. r=kats
> mozregression --repo autoland --launch 1a65a4910d55 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"
> firefox 523 MB, Web 378 MB, Web 29 MB
> ---------------------------------------------------
> mozregression --repo autoland --launch 1a65a4910d55
> firefox 172 MB, Web 393 MB, Web 29 MB