Enabling `mach try fuzzy` changes bash key bindings by default

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jimb, Assigned: ahal)

Tracking

unspecified
mozilla58

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

The process of enabling `mach try fuzzy` runs the fzf installation script, which by default edits the user's .bashrc file and changes the readline key bindings in the shell. This isn't required to use the fuzzy try chooser, and it's disruptive to bash users' habits (overriding C-t and C-r, especially), so it should not be done by default.

(In my particular case, I didn't read the prompts that the try fuzzy installation prompt printed carefully; I assumed it would only affect mach's behavior, and I was prepared for exploration and surprises there. I keep shell windows open for a long time, so I didn't happen to notice the key binding changes until I had to reboot for an update, so I made no association between the `try fuzzy` setup and these changes to bash's behavior; I assumed it was Fedora's change. It took a bit of investigation to figure out what was going on.)
Yes this is bad, my apologies. I think the shell integrations are useful, but we shouldn't be installing them as part of |mach try fuzzy|. Ideally I'd like the bootstrap code to live under /python/mozboot such that running |mach try fuzzy| only installs the binary, whereas running |mach bootstrap| also prompts to install the shell extensions (and doing a better job of explaining what that means).
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment on attachment 8925758 [details]
Bug 1414894 - [tryselect] Don't install shell extensions when bootstrapping fzf for |mach try fuzzy|,

https://reviewboard.mozilla.org/r/196922/#review202266
Attachment #8925758 - Flags: review?(armenzg) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0b47601baec
[tryselect] Don't install shell extensions when bootstrapping fzf for |mach try fuzzy|, r=armenzg
https://hg.mozilla.org/mozilla-central/rev/f0b47601baec
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.