1414897 - render the target_tasks_method template in release promotion

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

I tried to run test-action-callback against desktop in maple I get this:

Traceback (most recent call last):
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/mach_commands.py", line 288, in test_action_callback
    test=True)
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/actions/registry.py", line 282, in trigger_action_callback
    cb(Parameters(**parameters), input, task_group_id, task_id, task)
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/actions/release_promotion.py", line 265, in release_promotion_action
    taskgraph_decision({}, parameters=parameters)
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/decision.py", line 126, in taskgraph_decision
    write_artifact('target-tasks.json', tgg.target_task_set.tasks.keys())
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/generator.py", line 139, in target_task_set
    return self._run_until('target_task_set')
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/generator.py", line 287, in _run_until
    k, v = self._run.next()
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/generator.py", line 245, in _run
    target_tasks = set(fltr(target_task_set, self.parameters))
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/filter_tasks.py", line 34, in filter_target_tasks
    fn = target_tasks.get_method(attr)
  File "/home/rail/work/mozilla/repos/gecko/taskcluster/taskgraph/target_tasks.py", line 24, in get_method
    return _target_task_methods[method]
KeyError: u'%(project)s_desktop_promotion'

%(project)s is never evaluated. Should be easy to fix.

Comment 1

[Rail Aliiev [:rail]]

Attachment: Bug 1414897 - render the target_tasks_method template in release promotion

Review commit: https://reviewboard.mozilla.org/r/196716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196716/

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8925604 [details]
Bug 1414897 - render the target_tasks_method template in release promotion

https://reviewboard.mozilla.org/r/196716/#review202084

Looks like this is the first time we ran desktop in a long time :) Thanks Rail!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535fc0791de6
render the target_tasks_method template in release promotion r=aki

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/535fc0791de6