1414947 - elfhack/elf.cpp:167 possible memory leak

Status: RESOLVED INCOMPLETE

(Firefox Build System :: General, defect)

Description

[jbonnafo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

Editing elf.cpp code, there is a possible memory leak at line 167.


Actual results:

if safety checks line 162 fails, then the shdr oject is not destroyed.


Expected results:

If safety check fails, shrd should be destroyed accordingly.

Comment 1

[jbonnafo]

Hello,

I would like to submit a patch proposal for this issue, who should be added as reviewer in Phabricator?

Thanks,

Comment 2

[Matthias Versen [:Matti]]

Maybe mike can answer your question

Comment 3

[jbonnafo]

Attachment: Bug 1414947 - elfhack/elf.cpp:167 possible memory leak

Review commit: https://reviewboard.mozilla.org/r/200412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200412/

Comment 4

[jbonnafo]

Hello,

I have submitted a patch proposal using mozreview.
I am not used to this process, please do not hesitate to contact me if this needs to be re submitted.

Thanks,

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8929117 [details]
Bug 1414947 - elfhack/elf.cpp:167 possible memory leak

We're throwing a runtime error, there's no need to delete things here.

Comment 6

[jbonnafo]

Thanks for the quick feedback.
I think that this case can be closed, there is no need to amend the source code.