1414958 - UnicodeDecodeError while parsing process output

Status: NEW

(Firefox Build System :: General, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: full_log.tar.xz

20:23:06     INFO - Setting retcode to 1 from z:\build\build\src\testing\xpcshell\selftest.py
20:23:06     INFO - Return code from mach python-test: 1
20:23:06     INFO - Exception in thread ProcessReader:
20:23:06     INFO - Traceback (most recent call last):
20:23:06     INFO -   File "c:\mozilla-build\python\lib\threading.py", line 801, in __bootstrap_inner
20:23:06     INFO -     self.run()
20:23:06     INFO -   File "c:\mozilla-build\python\lib\threading.py", line 754, in run
20:23:06     INFO -     self.__target(*self.__args, **self.__kwargs)
20:23:06     INFO -   File "z:/build/build/src\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 986, in _read
20:23:06     INFO -     callback(line.rstrip())
20:23:06     INFO -   File "z:/build/build/src\testing/mozbase/mozprocess\mozprocess\processhandler.py", line 904, in __call__
20:23:06     INFO -     e(*args, **kwargs)
20:23:06     INFO -   File "z:/build/build/src\python/mach_commands.py", line 211, in _line_handler
20:23:06     INFO -     if 'FAILED' in line.rsplit(' ', 1)[-1]:
20:23:06     INFO - UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 88: ordinal not in range(128)
20:23:06     INFO - 1
20:23:06     INFO - z:/build/build/src/testing/testsuite-targets.mk:263: recipe for target 'check' failed
20:23:06     INFO - mozmake.EXE: *** [check] Error 1

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1414958 - Better handle Unicode in `mach python-test`

I suspect this will yield a failure in self.log() on line 199. But
I want to make sure before I ask for review.

Review commit: https://reviewboard.mozilla.org/r/196816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196816/

Comment 2

[Gregory Szorc [:gps]]

Please try the patch I just uploaded to MozReview. I think it will still error. But I want to be sure.

Comment 3

[Marco Castelluccio [:marco]]

Here's the try build where I saw the error: https://treeherder.mozilla.org/#/jobs?repo=try&revision=60ca074ddeef40e1b8bc6369ab29f94fe70add18.
You could get a one-click loaner (is Windows supported?) to test your change or you could send that patchset + your patch to try.