1414962 - xpcshell selftests are failing in coverage builds

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Marco Castelluccio [:marco]]

Here's the log: https://bugzilla.mozilla.org/attachment.cgi?id=8925671.

It could simply be a timeout.

Comment 1

[Marco Castelluccio [:marco]]

Yes, increasing the timeout fixed the problem.

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8926799 [details] [diff] [review]
Patch

Review of attachment 8926799 [details] [diff] [review]:
-----------------------------------------------------------------

will other xpcshell tests have this timeout?

::: testing/xpcshell/selftest.py
@@ +462,5 @@
>          logger = structured.commandline.setup_logging("selftest%s" % id(self),
>                                                        {},
>                                                        {"tbpl": self.log})
>          self.x = XPCShellTests(logger)
> +        self.x.harness_timeout = 15 if not mozinfo.info["ccov"] else 60

is it ccov or coverage?  I want to find a way to easily query where we adjust tests/tools for coverage, ideally searching for coverage to get everything.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> will other xpcshell tests have this timeout?

No, just the selftests.

> ::: testing/xpcshell/selftest.py
> @@ +462,5 @@
> >          logger = structured.commandline.setup_logging("selftest%s" % id(self),
> >                                                        {},
> >                                                        {"tbpl": self.log})
> >          self.x = XPCShellTests(logger)
> > +        self.x.harness_timeout = 15 if not mozinfo.info["ccov"] else 60
> 
> is it ccov or coverage?  I want to find a way to easily query where we
> adjust tests/tools for coverage, ideally searching for coverage to get
> everything.

It's ccov: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mozinfo.py#98.
I agree! I filed bug 1415840 for unifying the ways we modify things for coverage.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc457cd08715
Increase timeout for xpcshell selftest in code coverage builds. r=jmaher

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/fc457cd08715