Closed Bug 1414962 Opened 5 years ago Closed 5 years ago

xpcshell selftests are failing in coverage builds

Categories

(Testing :: Code Coverage, defect)

Product:
Testing
Component:
Code Coverage
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

Patch
1.30 KB, patch
jmaher
: review+
Details | Diff | Splinter Review 
Here's the log: https://bugzilla.mozilla.org/attachment.cgi?id=8925671.

It could simply be a timeout.
Yes, increasing the timeout fixed the problem.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Attached patch Patch — — Splinter Review 
Assignee: nobody → mcastelluccio
Status: RESOLVED → REOPENED

        Attachment #8926799 -
        Flags: review?(jmaher)
Resolution: FIXED → ---

    
  
Blocks: 1404433

    
    

    
  
Comment on attachment 8926799 [details] [diff] [review]
Patch

Review of attachment 8926799 [details] [diff] [review]:
-----------------------------------------------------------------

will other xpcshell tests have this timeout?

::: testing/xpcshell/selftest.py
@@ +462,5 @@
>          logger = structured.commandline.setup_logging("selftest%s" % id(self),
>                                                        {},
>                                                        {"tbpl": self.log})
>          self.x = XPCShellTests(logger)
> +        self.x.harness_timeout = 15 if not mozinfo.info["ccov"] else 60

is it ccov or coverage?  I want to find a way to easily query where we adjust tests/tools for coverage, ideally searching for coverage to get everything.

        Attachment #8926799 -
        Flags: review?(jmaher) → review+

    
    

    
  
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #3)
> will other xpcshell tests have this timeout?

No, just the selftests.

> ::: testing/xpcshell/selftest.py
> @@ +462,5 @@
> >          logger = structured.commandline.setup_logging("selftest%s" % id(self),
> >                                                        {},
> >                                                        {"tbpl": self.log})
> >          self.x = XPCShellTests(logger)
> > +        self.x.harness_timeout = 15 if not mozinfo.info["ccov"] else 60
> 
> is it ccov or coverage?  I want to find a way to easily query where we
> adjust tests/tools for coverage, ideally searching for coverage to get
> everything.

It's ccov: https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/mozinfo.py#98.
I agree! I filed bug 1415840 for unifying the ways we modify things for coverage.

    
    

    
  
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc457cd08715
Increase timeout for xpcshell selftest in code coverage builds. r=jmaher

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/fc457cd08715
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

          You need to log in
          before you can comment on or make changes to this bug.