Closed
Bug 1414977
Opened 7 years ago
Closed 7 years ago
New vertex attrib validation with robust_buffer_access_behavior (RBAB) causes DrawElements to fail
Categories
(Core :: Graphics: CanvasWebGL, defect, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | + | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
References
()
Details
(Whiteboard: gfx-noted)
Attachments
(3 files)
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jgilbert
Priority: -- → P2
Assignee | ||
Comment 1•7 years ago
|
||
This exhibits with angle disabled, and triangles fail to draw. Turning webgl.force-index-validation:true causes everything to draw again.
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8925748 [details] Bug 1414977 - Skip DrawElements if !indexCount, not !lastVert. - https://reviewboard.mozilla.org/r/196908/#review202066 lgtm. Thanks!
Attachment #8925748 -
Flags: review?(dmu) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Since this was a huge regression for Linux, we absolutely need a test for it. I needed to make the pref trinary in order to test it, though. (1 means force-validation, -1 means force-skip-validation, 0 means default behavior)
Comment 9•7 years ago
|
||
[Tracking Requested - why for this release]: Moving tracking flag over from the duplicate bug.
status-firefox58:
--- → affected
tracking-firefox58:
--- → ?
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8925770 [details] Bug 1414977 - Add test for drawing without index validation. - https://reviewboard.mozilla.org/r/196944/#review202092 lgtm!
Attachment #8925770 -
Flags: review?(dmu) → review+
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8925769 [details] Bug 1414977 - Allow webgl.force-index-validation:-1 to disable index validation for testing. - https://reviewboard.mozilla.org/r/196942/#review202094 r=me. thanks!
Attachment #8925769 -
Flags: review?(dmu) → review+
Comment 12•7 years ago
|
||
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0a66ad2d873 Allow webgl.force-index-validation:-1 to disable index validation for testing. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/25856ffb9083 Add test for drawing without index validation. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/d2580222abc7 Skip DrawElements if !indexCount, not !lastVert. - r=daoshengmu
Assignee | ||
Comment 13•7 years ago
|
||
Green so far, so I pushed to inbound: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de532e7f92b8eb28df609fc3578f5e845fe701ed&selectedJob=142623539
Assignee | ||
Updated•7 years ago
|
Severity: normal → critical
Priority: P2 → P1
Assignee | ||
Updated•7 years ago
|
Whiteboard: gfx-noted
Assignee | ||
Updated•7 years ago
|
Summary: New vertex attrib validation with skipping index validation can cause drawing to fail → New vertex attrib validation with robust_buffer_access_behavior (RBAB) causes DrawElements to fail
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c0a66ad2d873 https://hg.mozilla.org/mozilla-central/rev/25856ffb9083 https://hg.mozilla.org/mozilla-central/rev/d2580222abc7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•7 years ago
|
status-firefox56:
--- → unaffected
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•