Hook to manual trigger nightlies broken

RESOLVED FIXED

Status

Taskcluster
General
--
major
RESOLVED FIXED
13 days ago
7 days ago

People

(Reporter: aryx, Assigned: tomprince)

Tracking

({leave-open})

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

https://treeherder.mozilla.org/logviewer.html#?job_id=142563452&repo=mozilla-central

Manual triggering nightlies from https://tools.taskcluster.net/hooks/project-releng/nightly-desktop%2Fmozilla-central creates failing jobs:

TypeError: target_tasks_nightly_win32() takes exactly 3 arguments (2 given) 

https://hg.mozilla.org/mozilla-central/rev/f8903937a76e#l5.298

vs.

https://hg.mozilla.org/mozilla-central/rev/f8903937a76e#l5.334

Regression from bug 1410513.
Flags: needinfo?(mozilla)
(Assignee)

Updated

13 days ago
Assignee: nobody → mozilla
Flags: needinfo?(mozilla)
Keywords: leave-open
Comment hidden (mozreview-request)
(Assignee)

Comment 2

13 days ago
We should find some way to test these all can be called, even if nothing checks their behavior.

Comment 3

13 days ago
mozreview-review
Comment on attachment 8925725 [details]
Bug 1414988: Update recursive calls to `target_tasks_*` functions;

https://reviewboard.mozilla.org/r/196866/#review202074
Attachment #8925725 - Flags: review?(dustin) → review+

Comment 4

13 days ago
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 2 changesets with 1 changes to 1 files (+1 heads)
remote: 
remote: ***************************** ERROR ******************************
remote: Your try syntax would not trigger any jobs. Either specify a build
remote: with '-p' or an arbitrary job with '-j'. If you intended to push
remote: without triggering any jobs, omit the try syntax completely.
remote: 
remote: For more information, see https://wiki.mozilla.org/Try.
remote: ******************************************************************
remote: 
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.c_try_warning hook failed
abort: push failed on remote

Comment 5

13 days ago
Aryx, I did play with try a bit and got a Nightly manually triggered. No idea if that covers any codepath here.

Anyway, we know that we won't get a nightly at 10am UTC, right? Want to land this?
Flags: needinfo?(aryx.bugmail)
We should get a Nightly. The automated Nightlies last night got canceled a) to pick up the merges which landed shortly after they started b) to try to reproduce an issue. So only manual triggering should be broken and nightly builds triggered by the cron job start normally.
Flags: needinfo?(aryx.bugmail)

Comment 7

13 days ago
Decision task by cron actually burned, https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=c2fe4b3b1b930b3e7fdb84eae44cec165394f322&filter-searchStr=night&selectedJob=142672364.
That was from the manually requested nightlies, the scheduled nightlies ran on https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=4ea775c267be77107929d68799628a66027f3172&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry

Comment 9

13 days ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9f51e91195a6
Update recursive calls to `target_tasks_*` functions; r=dustin

Comment 10

13 days ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/7851d6768dfd
Update recursive calls to `target_tasks_*` functions; r=dustin a=nightly-fix
https://hg.mozilla.org/mozilla-central/rev/7851d6768dfd

Comment 12

12 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9f51e91195a6
(Assignee)

Updated

12 days ago
Status: NEW → RESOLVED
Last Resolved: 12 days ago
Resolution: --- → FIXED
1 failures in 849 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* gecko-decision: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1414988&startday=2017-11-06&endday=2017-11-12&tree=all
You need to log in before you can comment on or make changes to this bug.