1414993 - Separate off the content of New Tab Override from "When Nightly starts"

Status: RESOLVED DUPLICATE of bug 1417155

(Firefox :: Settings UI, defect, P4)

Description

[magicp]

Attachment: newtab-override-in-preferences.png

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 ID:20171106100122

Steps to reproduce:
1. Start Nightly
2. Install any newtab override add-ons (e.g. New Tab Override)
3. Override new tab page
4. Open about:preferences

Actual Results:
The content of New Tab Override is displayed in "When Nightly starts".
"New Tab" is not startup page. Users will misunderstand startup page and new tab.

Expected Results:
It should be separated off from "When Nightly starts". Make "New Tab" section.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Markus, what do you think about this? I think the recommendation makes sense because the left-side of the screenshot isn't obvious that "when Firefox starts" will use the new tab page.

Comment 2

[Markus Jaritz [:designakt] (UX)]

Yes it does... I think we should add newTab to that list too.
We might want to change the order though. newTab on top, 
as it is the default choice, and home page at the bottom, 
to be close to the next section about defining the home page.

like this:
https://mozilla.invisionapp.com/share/6HCITJKP8#/242994341_Jazz_-_Preferences_-_General_-_V4_-_00_Default

Comment 3

[Markus Jaritz [:designakt] (UX)]

When we do that, we should place the newTab override notice 
directly after the newTab option. Like this:
https://mozilla.invisionapp.com/share/6HCITJKP8#/242994342_Jazz_-_Preferences_-_General_-_V4_-_01_Override_NewTab

Comment 4

[magicp]

(In reply to Markus Jaritz [:designakt] (UX) from comment #3)
> When we do that, we should place the newTab override notice 
> directly after the newTab option. Like this:

This notice is about "WHEN FIREFOX STARTS". Override newtab affects clicking "OPEN A NEW TAB".

Comment 5

[Markus Jaritz [:designakt] (UX)]

(In reply to magicp from comment #4)
> (In reply to Markus Jaritz [:designakt] (UX) from comment #3)
> > When we do that, we should place the newTab override notice 
> > directly after the newTab option. Like this:
> 
> This notice is about "WHEN FIREFOX STARTS". Override newtab affects clicking
> "OPEN A NEW TAB".

Yes. It is about what one sees when they start Firefox. If they chose to see newTab when Firefox starts, they should know iff newTab is controlled by an extension.

Comment 6

[magicp]

(In reply to Markus Jaritz [:designakt] (UX) from comment #5)

> Yes. It is about what one sees when they start Firefox. If they chose to see
> newTab when Firefox starts, they should know iff newTab is controlled by an
> extension.

No, this notice don't cover "OPEN A NEW TAB" after Firefox started.

Comment 7

[Markus Jaritz [:designakt] (UX)]

I am sorry, I completely missed the second part of the change you proposed.
I fully agree with adding an option for newTab to the "when Firefox starts" section.
The second part, the placement of the message that only appears if an extension changes ones newTab, does not justify it's own section though.
The newTab override message can be grouped with the newTab option under "when Firefox starts" as shown here:
https://mozilla.invisionapp.com/share/6HCITJKP8#/242994342_Jazz_-_Preferences_-_General_-_V4_-_01_Override_NewTab

(In reply to magicp from comment #6)
> No, this notice don't cover "OPEN A NEW TAB" after Firefox started.

I am not sure I understand what you mean by this... In my understanding, every newTab is controlled by the extension, if it overrides newTab, so also the newTab one seens when starting Firefox, will be affected.

Comment 8

[magicp]

(In reply to Markus Jaritz [:designakt] (UX) from comment #7)

> I am not sure I understand what you mean by this... In my understanding,
> every newTab is controlled by the extension, if it overrides newTab, so also
> the newTab one seens when starting Firefox, will be affected.

Yes, so why do you add override message into "when Firefox starts" group? This meaning is ONLY affects when Firefox starts.

Comment 9

[Markus Jaritz [:designakt] (UX)]

(In reply to magicp from comment #8)
> (In reply to Markus Jaritz [:designakt] (UX) from comment #7)
> 
> > I am not sure I understand what you mean by this... In my understanding,
> > every newTab is controlled by the extension, if it overrides newTab, so also
> > the newTab one seens when starting Firefox, will be affected.
> 
> Yes, so why do you add override message into "when Firefox starts" group?

Because this is where we mention newTab.
And people will know that they choose an extension controlled page to show when Firefox starts, when they pick that option.

> This meaning is ONLY affects when Firefox starts.
Sorry, I can't follow that... The message clearly says: 
An extension, XYZ, controls your New Tab page.
(it does not say anything about only on startup)

Comment 10

[magicp]

(In reply to Markus Jaritz [:designakt] (UX) from comment #9)

> Because this is where we mention newTab.
> And people will know that they choose an extension controlled page to show when Firefox starts, when they pick that option.

New tab option is agree. But override message should be separated from "when Firefox starts" group. In case of homepage override message, is it in "when Firefox starts" group? Answer is NO.

> > This meaning is ONLY affects when Firefox starts.
> Sorry, I can't follow that... The message clearly says: 
> An extension, XYZ, controls your New Tab page.
> (it does not say anything about only on startup)

Again, Users will misunderstand startup page and new tab.

Comment 11

[Markus Jaritz [:designakt] (UX)]

(In reply to magicp from comment #10)
> Again, Users will misunderstand startup page and new tab.

So let's put my proposed solution to the test. 
If we notice people having a problem with it, 
we can add the additional category you propose.

Comment 12

[magicp]

(In reply to Markus Jaritz [:designakt] (UX) from comment #11)

> So let's put my proposed solution to the test. 
> If we notice people having a problem with it, 
> we can add the additional category you propose.

I don't agree, because how do you get and decide it? In general, latter is disadvantage. Before put your proposed solution, we should get feedback from other members about your and my proposed solutions. I am a user and filed this bug.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

I can see both sides here, but I think we should take an incremental approach such as the one that Markus has provided. It will be easier for us to add another line to the "When Firefox starts" section for now, and if/when we add another section for the New Tab or specific overrides we will be able to take a broader look at what might fit in that type of section.

Also, @magicp may I please ask that you tone down your language here? We are all users of the product and we all hope to make it better.