1415007 - Update dom/imptests/testharness.js with the latest one

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

I'd like to use the feature which was added in this commit.

https://github.com/w3c/web-platform-tests/commit/673213788073554b8579f75bea6895a33c59ac20

:jgraham, what is the right way to update dom/imptests/testharness.js in these days?

The testharness.js in our testing/web-platform/tests/resources has already included the change what I want, so it's OK just replacing dom/imptests one with it?

Comment 1

[Hiroyuki Ikezoe (:hiro)]

This needs for bug 1413817.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Idiot!

Comment 3

[James Graham [:jgraham]]

Why do you want to use the imptest version vs the one in testing/web-platform/tests? The idea is to remove imptests entirely as soon as possible.

Comment 4

[Brian Birtles (:birtles, Feb 26~ parental leave)]

There are two cases:

a) some tests are destined for web-platform-tests but we can't move them there yet because they test not-yet-specified behavior. Once that behavior is specified, we'll move them there.

b) some tests are very similar to tests in web-platform-tests but test Gecko-specific behavior, and in some cases require chrome privileges. We'd like to continue using the same testing library, i.e. testharness.js, so that developers are not constantly switching back and forth between mochitests and testharness.js (and invariably introducing bugs in the process).

Comment 5

[James Graham [:jgraham]]

For a) there is a convention to use .tentative. in the filename and upstream the tests anyway, assuming the behaviour reflects what you think the spec will eventually look lke.

For b) it might make sense to use testing/web-platform/mozilla/tests/ which is intended for testharness-based tests that can't yet be upstreamed. But they still can't use chrome privileges. I would be interested to know if there are cases that require something from the SpecialPowers that aren't testing gecko-specific behaviour but just require some non-web-exposed feature to set up the test conditions.

For imptest, you can of course just copy the latest testharness.js there and see if anything breaks, but there's a plan to remove that at some point, so it would be good if we can avoid more things relying on it.