1415010 - Bind onanimationxx handler before creating EventWatcher in css-animations/file_event-order.html

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

In the test, we are waiting for being the EventWatcher.wait_for promise resolved, and then check received events that we got by onanimationxxx handler.  So, if we don't bind the handlers before the EventWatcher, no one ensures that we receive events in the handler before the EventWatcher.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1415010 - Use arrow functions.

Review commit: https://reviewboard.mozilla.org/r/196916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196916/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1415010 - Bind onanimationxx handlers before creating EventWatcher.

So that we can surely receive these animation events in the handler before
the EventWatcher receives the events.

Review commit: https://reviewboard.mozilla.org/r/196918/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196918/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eae4ae2298ead9d1b849905ab528c5c06bc2ba0a

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8925755 [details]
Bug 1415010 - Use arrow functions.

https://reviewboard.mozilla.org/r/196916/#review202076

Comment 5

[Brian Birtles (:birtles)]

Comment on attachment 8925756 [details]
Bug 1415010 - Bind onanimationxx handlers before creating EventWatcher.

https://reviewboard.mozilla.org/r/196918/#review202078

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Thanks for the quick review!  I will land them once after I confirmed the try results.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e75110474d54
Use arrow functions. r=birtles
https://hg.mozilla.org/integration/autoland/rev/242c0719c3bf
Bind onanimationxx handlers before creating EventWatcher. r=birtles

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e75110474d54
https://hg.mozilla.org/mozilla-central/rev/242c0719c3bf