Closed Bug 1415010 Opened 3 years ago Closed 3 years ago

Bind onanimationxx handler before creating EventWatcher in css-animations/file_event-order.html

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(2 files)

In the test, we are waiting for being the EventWatcher.wait_for promise resolved, and then check received events that we got by onanimationxxx handler.  So, if we don't bind the handlers before the EventWatcher, no one ensures that we receive events in the handler before the EventWatcher.
Comment on attachment 8925755 [details]
Bug 1415010 - Use arrow functions.

https://reviewboard.mozilla.org/r/196916/#review202076
Attachment #8925755 - Flags: review?(bbirtles) → review+
Comment on attachment 8925756 [details]
Bug 1415010 - Bind onanimationxx handlers before creating EventWatcher.

https://reviewboard.mozilla.org/r/196918/#review202078
Attachment #8925756 - Flags: review?(bbirtles) → review+
Thanks for the quick review!  I will land them once after I confirmed the try results.
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e75110474d54
Use arrow functions. r=birtles
https://hg.mozilla.org/integration/autoland/rev/242c0719c3bf
Bind onanimationxx handlers before creating EventWatcher. r=birtles
https://hg.mozilla.org/mozilla-central/rev/e75110474d54
https://hg.mozilla.org/mozilla-central/rev/242c0719c3bf
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.