Closed Bug 1415028 Opened 2 years ago Closed 2 years ago

Remove unnecessary call to LoadEME and refine code in test_eme_sample_groups_playback.html

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: kikuo, Assigned: kikuo)

References

Details

Attachments

(1 file)

See Bug 1414463,

This test aims to check whether samples' keyid can be parsed and assigned correctly from sgpd (sbgp in traf, sgpd in stbl) or not.
It's enough to only call LoadEME once to make sure the license response is updated to CDM before starting playback.


An additional call to LoadEME may result to Bug 1414462, Bug 1414463 as Bug 1395922 makes it easier to appear.
Bug 1342336 is an identical issue just like Bug 1414463, but it's reported 9 months ago.
Component: Audio/Video → Audio/Video: Playback
Priority: -- → P3
Comment on attachment 8925806 [details]
Bug 1415028 - Remove unnecessary code which may lead to intermittent error.

https://reviewboard.mozilla.org/r/196982/#review202142
Attachment #8925806 - Flags: review?(jwwang) → review+
Comment on attachment 8925806 [details]
Bug 1415028 - Remove unnecessary code which may lead to intermittent error.

https://reviewboard.mozilla.org/r/196982/#review202144

Thanks for the review
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea03ba856101
Remove unnecessary code which may lead to intermittent error. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/ea03ba856101
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.